Uh oh!
There was an error while loading. Please reload this page.
feat(service-analytics): bucket + format date dimensions (no more epoch millis) - #1682
Merged
Merged
Conversation
…ch millis) Date dimensions on trend charts rendered the raw stored timestamp (`1777632968596`) because a plain selected date dimension grouped by the raw field and the value was never formatted. - DatasetExecutor: a selected date dimension that declares an explicit `dateGranularity` (single-entry compiled `granularities`) is promoted to a time dimension, so it buckets (one row per month/day/…) instead of one row per raw timestamp. Dimensions already carried by `selection.timeDimensions` (e.g. compareTo) are untouched. - dimension-labels: grouped date values are formatted to a sort-stable label per granularity (year `2026`, quarter `2026-Q2`, month `2026-04`, day/week `2026-04-15`); parses epoch-ms/epoch-s/ISO defensively and leaves non-dates unchanged. - showcase chart-gallery dataset: `created_at` gains `dateGranularity: 'month'` so the trend widgets bucket monthly. Browser-verified on the showcase Chart Gallery: "Tasks Created (monthly)" now shows `2026-05` / `2026-06` buckets. turbo build 72/72, test 123/123 green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Uh oh!
There was an error while loading. Please reload this page.
xuyushun441-sys added a commit
that referenced
this pull request
Jun 13, 2026
…ing (#1803) * chore: bump objectui to 76c38108544d test(e2e): lookup quick-filter coverage (CRM parity) (#1682) objectui@76c38108544dd92abf965c0e07b0e4d92264708a * feat(service-ai): open framework AI is query-only, declines app-building The unified `data_chat` persona (ADR-0040) advertises that it can BUILD or CHANGE the application, but that capability is supplied entirely by the cloud AI Studio plugin's `metadata_authoring`/`solution_design` skills and their tools. On the open single-env framework those skills are not registered, so the authoring tools never resolve — yet the LLM, still reading the "you can build" persona, role-plays designing a whole system (emitting design docs it has no tools to execute). Users saw the standalone open framework "develop" a full 进销存 app that it could not actually create. Fix: in buildSystemMessages, when no authoring (build-register) skill is active, append a deployment-capability note constraining the assistant to data/query and instructing it to decline build requests instead of pretending. Keyed off actual skill presence, so cloud/EE (AI Studio loaded) keeps the full build UX with zero extra wiring. Adds tests for both the absent and present build-register cases. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Jack Zhuang <277994282+os-zhuang@users.noreply.github.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
xuyushun441-sys pushed a commit
that referenced
this pull request
Jun 13, 2026
test(e2e): lookup quick-filter coverage (CRM parity) (#1682) objectui@76c38108544dd92abf965c0e07b0e4d92264708a
xuyushun441-sys added a commit
that referenced
this pull request
Jun 13, 2026
Picks up objectui#1684 — interface pages (ADR-0047) now render data columns when the referenced source view is served hollow (columns only in named views), instead of a bare row-number grid. Also rolls up #1680/#1681/#1682 (toolbar viz dropdown, URL filter persistence, lookup quick-filter e2e) that landed after the previous pin (76c38108544d). build-console.sh builds clean at this SHA (33 MB dist, verified locally). Co-authored-by: Jack Zhuang <277994282+os-zhuang@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Date dimensions on trend charts rendered the raw stored timestamp (
1777632968596) instead of a readable date — a plain selected date dimension grouped by the raw field and the value was never formatted. (Reported alongside the lookup-id / select-value issue fixed in #1680.)Fix
dateGranularity(single-entry compiledgranularities) is promoted to a time dimension, so it buckets (one row per month/day/…) instead of one per raw timestamp. Dimensions already carried byselection.timeDimensions(e.g.compareTo) are left untouched.year→2026,quarter→2026-Q2,month→2026-04,day/week→2026-04-15. Parses epoch-ms / epoch-s / ISO defensively; non-dates pass through unchanged.chart-gallerydataset'screated_atgainsdateGranularity: 'month'.Verification
Browser-tested on the showcase Chart Gallery: "Tasks Created (monthly)" x-axis now reads
2026-05/2026-06(was epoch millis); status/priority bars still show resolved labels. New unit tests forformatDateBucket+ date-dimension resolution.turbo build72/72,turbo test123/123 green.Completes the analytics dimension-display follow-up (after #1680 labels + #1681 report rendering).
🤖 Generated with Claude Code