Uh oh!
There was an error while loading. Please reload this page.
fix(showcase): flow example fixes + nested-pause (approval-in-subflow) example - #1695
Merged
Conversation
…low writes The showcase_resilient_sync flow's try/catch demo flags push failures by writing task.sync_status / task.sync_error from its catch region — but the showcase_task object never declared those fields, so the catch itself failed with "no such column: sync_status" and the whole run failed instead of demonstrating structured error handling. Found by step-by-step browser E2E of every showcase flow; with the fields in place the flow now completes: push retries exhaust → catch flags the task → run completed with the catch step in the run log. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Adds the worked example for nested durable pause (linked runs, #1693): - showcase_closure_signoff: reusable approval subflow (manager sign-off, approve/reject branches recorded into its `decision` output) - showcase_project_closure: on project completion, invokes the sign-off subflow — the child suspends on its approval node, suspending the parent at the subflow node too; the decision bubbles back up and the owner is notified with the outcome Also gates showcase_budget_approval on the budget actually CHANGING (`budget != previous.budget`) — it previously fired on every update of a large-budget project, colliding with any other approval flow on the same record (approvals dedupe pending requests per record), which broke the new example and was wrong on its own terms. Verified live in the browser: complete a project → parent run paused at `signoff` (correlation subflow:<child>) + child paused at `ask_signoff` → approve via /api/v1/approvals → child completes down the approve edge and bubbles: parent resumes, notify_owner runs, both runs completed; the Studio Runs panel shows the same run transitioning paused → completed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three showcase flow improvements found/driven by step-by-step browser E2E of every flow:
showcase_taskmissingsync_status/sync_error— the resilient-sync try/catch demo writes these from its catch region but the object never declared them, so the catch failed with "no such column" and the run failed instead of demonstrating structured error handling. Verified after the fix: retries exhaust → catch flags the task → run completed with the catch step in the run log.showcase_closure_signoff(reusable approval subflow) +showcase_project_closure(on project completion, requests sign-off through the subflow, then notifies the owner with the bubbled decision).showcase_budget_approvalnow gates on the budget actually changing (budget != previous.budget) — it previously fired on every update of a large-budget project, colliding with any other approval flow on the same record (approvals dedupe pending requests per record).Test plan
signoff(correlation: subflow:<child>) + child paused atask_signoff→ approve via/api/v1/approvals→ child completes down the approve edge and bubbles: parent resumes,notify_ownerruns, both runs completed🤖 Generated with Claude Code