Uh oh!
There was an error while loading. Please reload this page.
feat(spec): Report matrix columns (across) + drilldown flag (ADR-0021 D2) - #1732
Merged
Conversation
…0021 D2) A matrix report now pivots `rows` (down) × `columns` (across dimension names) with `values` in the cells — the pivot triple ADR-0021 D2 specified; the flattened rows-only stopgap retires. Joined blocks gain the same `columns` field. `drilldown` (boolean, default true) declares click-through from an aggregated row/cell to the underlying records; the host resolves the dataset's object and dimension→field mapping. reportForm surfaces both in the Dataset binding section (columns gated on type == 'matrix'); the showcase matrix fixture moves to the true pivot form. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Jun 11, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the remaining two fields of the ADR-0021 D2 report pivot grammar (see
docs/adr/0021-analytics-dataset-semantic-layer.md§D2):columns?: string[]— dimension names across. Amatrixreport pivotsrows(down) ×columns(across) withvaluesin the cells, replacing the flattened rows-only stopgap. Also added toJoinedReportBlockSchema.drilldown: boolean(defaulttrue) — declares click-through from an aggregated row/cell to the underlying records (dataset-backed; the host resolves the dataset'sobjectand dimension→field mapping).reportFormsurfaces both in the Dataset binding section (columnsgated ondata.type == 'matrix'). The showcase matrix fixture (showcase_status_priority_matrix) moves to the true pivot form (rows: ['status'], columns: ['priority']).Changeset: minor on
@objectstack/spec(fixed group).Downstream: objectui implements the real cross-tab renderer + drill on these fields (PR to follow).
Test plan
pnpm build+pnpm test— 6528 passed (new matrix/drilldown cases included)pnpm test— 20 passed🤖 Generated with Claude Code