Uh oh!
There was an error while loading. Please reload this page.
fix(i18n): correct stale page-type help text in metadata-form bundles - #1846
Merged
Conversation
The page `type` field help text listed `dashboard` (and implied grid/kanban/ calendar) as page types — wrong after the ADR-0047 page-type cleanup, where those are visualizations under Interface, not page kinds. Updated en/zh-CN/ ja-JP/es-ES to "page kind — list/record/home/app/utility; visualizations live under Interface", and fixed the stale zh-CN `kind` help text (record-page override mode, not "record/list/detail"). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last of the panel-audit follow-ups. The page
typefield's help text in the metadata-form translation bundles still read "page type (record, home, app, dashboard, etc.)" — listingdashboard(and implying grid/kanban/calendar) as page types. That's wrong after the ADR-0047 page-type cleanup: those are visualizations configured under Interface, not page kinds.Changes
packages/platform-objects/src/apps/translations/*.metadata-forms.generated.ts(hand-edited; the generator's--mergepreserves these):page.type.helpTextin en / zh-CN / ja-JP / es-ES → "page kind — list / record / home / app / utility; how a list page looks (grid / kanban / calendar) is a visualization set under Interface, not a page type".page.kind.helpText("页面种类分组（如 record / list / detail）") → matches the English ("record-page override mode: full or slotted").These bundles override the spec's inline
helpTextat runtime, so editingpage.form.tsalone would not have fixed the displayed Chinese/Japanese/Spanish text.Verification
pnpm --filter @objectstack/spec build(with dts) thentsc --noEmiton@objectstack/platform-objects→ 0 errors from these files (only an unrelated cached-dep dts artifact).🤖 Generated with Claude Code