Uh oh!
There was an error while loading. Please reload this page.
feat(cli): two flow anti-pattern lints — date-equality filters (#1874) + phantom aggregation (#1870) - #1950
Merged
Merged
Conversation
…1874) Extends the flow anti-pattern lint from trigger CONDITIONS to query FILTERS. A scheduled flow whose get_record filter binds a field directly / via $eq / $in to a time-function value (daysFromNow/today/now/...) silently matches nothing, because a Field.date stores a time component and an exact match against a re-computed timestamp never holds — the bug the templates discrete-tier alerts hit. Range ops ($gte/$lt day windows) are the correct shape and are exempt. New rule flow-date-equality-filter; advisory warning, never fails the build. 10 tests incl. false-positive guards (windows, $or, plain ranges, non-time eq). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 15 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
A node-config key naming a capability the automation engine lacks (aggregations/aggregate/groupBy/rollup/having) is silently ignored at runtime — the node runs and computes nothing (templates publication_rollup). Flag it and point the author to the data-layer equivalent: Field.summary for a cross-object rollup, Field.formula for a per-record computed value. New rule flow-phantom-aggregation; advisory warning. 3 tests. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Jun 16, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platform fixes#2 & #3 of the #1928/#1874/#1870 follow-up. Two new advisory build-time lints (warnings, never fail the build):
1.
flow-date-equality-filter(#1874)A get_record/query filter that binds a field directly, or via
$eq/$in, to a time-function value (daysFromNow/today/now/…). AField.datestores a time component, so an exact match against a re-computed timestamp silently returns nothing — exactly what the templates discrete-tier alerts hit (renewal_alert / evidence_expiring / document_expiring_soon). Range ops ($gte/$ltday windows) are the correct shape and are exempt. (Complements the existing trigger-condition equality lint.)2.
flow-phantom-aggregation(#1870)A node config key naming a capability the automation engine doesn't have (
aggregations/aggregate/groupBy/rollup/having). There is no aggregate node, so the key is silently ignored and the node computes nothing (templatespublication_rollup). Points the author toField.summary(cross-object rollup) /Field.formula(per-record).Tests
36/36 lint tests incl. false-positive guards (one-day windows,
$ormulti-tier, plain< today()ranges, non-time equality, ordinary script/function nodes). tsc clean.🤖 Generated with Claude Code