Uh oh!
There was an error while loading. Please reload this page.
feat(audit): sys_activity source pointer — ActivityPointer model (ADR-0052 §5) - #1957
Merged
Merged
Conversation
…(ADR-0052 §5) Add `source_object` / `source_id` to `sys_activity`. `object_name`/`record_id` say WHICH record an activity is about (the "regarding" record); the new pair points to the RICH ENTITY it was derived from — the email row in `sys_email`, the call/meeting task, the `sys_comment` — so the timeline drills from a one-line summary to the full record, and apps can query "all activities sourced from X". This completes `sys_activity` as a proper ActivityPointer base (cf. Dataverse ActivityPointer → Email/PhoneCall/Appointment; Salesforce ActivityTimeline → EmailMessage/Task/Event): one materialized, indexed timeline that references — never duplicates — the rich, separately-tabled communication entities. The structured, queryable replacement for an id buried in `metadata`. Deliberately NOT done (per the design review): extending the `type` enum with domain verbs (email/call/meeting) — that couples a shared platform primitive to one vertical's vocabulary. `type` stays neutral; domain kind rides in `metadata.kind`; the rich entity lives in its own table. - sys-activity.object.ts: + source_object, source_id (text, searchable, optional) - ADR-0052 §5 updated to the ActivityPointer model - Verified in the showcase: a source-pointed activity round-trips and is queryable by source_object; plugin-audit 18/18 tests pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Uh oh!
There was an error while loading. Please reload this page.
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 5 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ADR-0052 §5 — add
source_object/source_idtosys_activity, completing it as a proper ActivityPointer base.object_name/record_id= WHICH record the activity is about (the "regarding" record, e.g. a contact).source_object/source_id(new) = the rich entity the activity was derived from — the email row insys_email, a call/meeting task, asys_comment.So the timeline drills from a one-line summary to the full record, and apps can query "all activities sourced from
sys_email". This is the structured, queryable replacement for an id buried inmetadata.Why (design review with @jack)
Mainstream platforms all split rich communication entities (their own tables) from the timeline (a pointer/aggregation) — never cram an email into a generic activity blob:
Email/PhoneCall/AppointmentActivityPointerbase (+regardingobjectid)EmailMessage/Task/Eventsys_email/Interactionsys_activityis ObjectStack'sActivityPointer; it was missing the drill-to-source pointer. This adds it.Deliberately NOT done: extending the
typeenum withemail/call/meeting. That couples a shared platform primitive to one vertical's vocabulary (every domain has its own —interview,site_visit,inspection…), an endless treadmill.typestays neutral; domain kind rides inmetadata.kind; the rich entity lives in its own table.Verification (showcase, browser)
A source-pointed
sys_activityrow (regarding a project, sourced from a task) inserted → 201, and queryingsys_activityfiltered bysource_object='showcase_task'returned it with the pointer populated.plugin-audit18/18 tests pass; builds clean. (Demo row cleaned up.)🤖 Generated with Claude Code