Uh oh!
There was an error while loading. Please reload this page.
docs(adr): ADR-0058 — expression & predicate surface audit + consolidation (closes #1887) - #2087
Merged
Merged
Conversation
…olidation (closes#1887) Whole-surface audit (3 passes) of every authorable expression on the platform: one authoring language (ExpressionInput/CEL, ~50 declarations) but TWO runtime backends — a unified per-record CEL interpreter (works) and a FRAGMENTED compile-to-filter path (rls-compiler regex + celToFilter field-equality + read-scope-sql backend, no shared AST). That fragmentation is the root of the predicate-honesty debt: sharing `condition` never compiled (#1887), RLS `check` unenforced, inconsistent silent-fail policies. Decision: one canonical CEL→FilterCondition pushdown compiler on the interpreter's AST; the supported pushdown subset (no subqueries, ADR-0055); reconcile sharing #1887 + RLS check; one fail-policy matrix (compile-error / fail-closed-security / fail-soft-but-logged); a durable Expression Surface Conformance ledger. Scopes OUT the non-expression experimental subsystems (ADR-0056 D8). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A whole-surface audit + consolidation of every authorable expression on the platform (the expression-layer analogue of ADR-0056's permission landing). Decision-only ADR; implementation follows in phased PRs.
The finding
One authoring language (
ExpressionInput/CEL, ~50 declarations) but two runtime backends: a unified per-record CEL interpreter (@objectstack/formula, works) and a fragmented compile-to-filter path (rls-compiler4-form regex + sharingcelToFilterfield-equality +read-scope-sqlrich backend) that shares no AST. That fragmentation is the root of the predicate-honesty debt: sharingconditionnever compiled (#1887), RLScheckdeclared-but-unenforced, and inconsistent silent-fail policies (formula→null unlogged, hook→false, validation→skip, flow→throw, RLS→drop+warn, sharing→silent-empty).The decision
One canonical CEL→FilterCondition pushdown compiler on the interpreter's AST (retiring the regex +
celToFilter, feeding the existing rich SQL backend); the supported pushdown subset (no subqueries, ADR-0055); reconcile #1887 + RLScheck; one fail-policy matrix (compile-error / fail-closed-security / fail-soft-but-logged); a durable Expression Surface Conformance ledger. Non-expression experimental subsystems stay under ADR-0056 D8 (scoped out).Phasing: P1 compiler → P2 cutover + fail-policy → P3 close#1887 + RLS check → P4 conformance ledger.
Closes#1887.
🤖 Generated with Claude Code