Uh oh!
There was an error while loading. Please reload this page.
docs(currency): document field→tenant resolution chain; fix currencyMode; showcase demo - #2123
Merged
Conversation
…ncyMode; showcase demo Follows the currency-resolution work (#2102/#2119/#2121/#2122). Brings the skills + showcase in line with the now-implemented chain. - objectstack-ui SKILL: document `DatasetMeasure.currency` (ISO 4217) and its resolution order (measure → field `currencyConfig` → tenant default). - objectstack-data field-types: FIX a real doc bug — `currencyMode` was documented as `'multi'/'single'`, the schema is `'fixed'/'dynamic'`; add a "Currency resolution (ADR-0053)" note (field default → tenant default → plain number, never a hardcoded `$`). - objectstack-i18n SKILL: note the workspace regional defaults (timezone / locale / currency) — the `localization` settings, resolved onto ExecutionContext and exposed at `/auth/me/localization`. - showcase: declare a fixed `currencyConfig.defaultCurrency` on field-zoo's currency field (demonstrates + smoke-covers the symbol path); refresh the chart-gallery `budget`/`spent` comment, which claimed an unspecified-currency amount "must not show a $" — now it falls back to the tenant default. Verified: app-showcase builds (field + dataset parse); check:skill-docs in sync. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs / skills / showcase for the currency-resolution work
Brings the skills + showcase in line with the now-implemented chain (#2102 / #2119 / #2121 / #2122).
DatasetMeasure.currency(ISO 4217) + its resolution order (measure → fieldcurrencyConfig→ tenant default).currencyModewas documented as'multi'/'single', but the schema is'fixed'/'dynamic'; adds a "Currency resolution (ADR-0053)" note (field default → tenant default → plain number, never a hardcoded$).localizationsettings, resolved ontoExecutionContextand exposed at/auth/me/localization.currencyConfig.defaultCurrencyon field-zoo's currency field (demonstrates + smoke-covers the symbol path); refresh the chart-gallerybudget/spentcomment that claimed an unspecified-currency amount "must not show a $" — it now falls back to the tenant default.Verified
app-showcasebuilds (the new field config + dataset parse through spec).check:skill-docsin sync (body edits only; frontmatter unchanged).🤖 Generated with Claude Code