Uh oh!
There was an error while loading. Please reload this page.
feat(platform-objects): drop unused team kind from sys_business_unit (ADR-0057 D11) - #2143
Merged
Merged
Conversation
…t (ADR-0057 addendum D11) kind='team' collided head-on with the first-class sys_team object (hierarchical BusinessUnitGraphService vs flat TeamGraphService). kind is a display-only categorisation hint with zero repo usages, so narrow it to company|division|department|office|cost_center and drop the team picklist labels from the 4 generated locale bundles. No data migration. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 3 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First implementation increment of the ADR-0057 addendum (#2141) — PS-1 / D11.
What
Drops the unused
teamvalue fromsys_business_unit.kind:company | division | department | ~~team~~ | office | cost_center.Why
kind='team'collided head-on with the first-classsys_teamobject — akind='team'business unit walks the hierarchicalBusinessUnitGraphService, whilesys_teamis the flat better-auth collaboration grouping served byTeamGraphService.Two "team" concepts with different semantics and no UI distinction; this was the single
largest source of the "teams vs business units feel redundant" ambiguity the addendum
set out to remove.
Safety
kindis a display-only categorisation hint ("does not change graph semantics").kind: 'team'usages anywhere in the repo (seeds, showcase, tests) → no data migration.bu-rename-consistency.test.tsis scoped to labels and explicitly excludeskind, so it is unaffected.teampicklist labels are removed from the 4 generated locale bundles (en/zh-CN/ja-JP/es-ES), matching whatos i18n extract --mergeproduces.Changeset:
@objectstack/platform-objectsminor (schema narrowing, non-breaking in practice).Follow-ups (not in this PR)
nav_business_unitsto the hierarchy-security capability + gatenav_organizations/nav_invitationsonmultiOrgEnabled(needs avisible/requiresFeaturepredicate onNavigationItemfirst; the nav-render side may touch the console repo).sys_user.primary_business_unit_idprojection for "pick people by BU".🤖 Generated with Claude Code