Uh oh!
There was an error while loading. Please reload this page.
feat(spec): reject script actions with no executable binding + showcase execution tests - #2171
Merged
Merged
Conversation
…se execution tests Prevents the class of bug fixed in #2169, where `showcase_mark_done` declared `type: 'script'` but carried neither a `body` nor a `target`. AppPlugin only registers an engine handler for actions with a runnable binding, so the action fell through to the `'*'` wildcard lookup and failed at invocation with `Action '<name>' on object '*' not found` — a soft failure that build- and shape-level tests never caught. Two complementary layers: 1. Author/compile-time guard (root cause): `ActionSchema` now requires `body || target` when `type === 'script'` (a `superRefine`, mirroring the existing "non-script types require `target`" rule). `os build` / `defineAction` now reject the broken shape immediately, for every bundle. Verified against the full monorepo build — every shipped bundle still compiles, so this only rejects configurations that were already non-functional at runtime. Existing spec fixtures that relied on the looser rule were updated. 2. Execution-path test (catch-net): examples/app-showcase/test/actions.test.ts drives the real `actionBodyRunnerFactory` + QuickJS sandbox against the shipped actions — asserting Mark Done produces a handler and writes `{ done: true, progress: 100 }`. The prior coverage test only checked that each ActionType *appeared* in the bundle, which is what let #2169 ship. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 89 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up hardening for #2169 (the "Mark Done" runtime error). That bug shipped because a
type: 'script'action with neitherbodynortargetis schema-valid and passes the coverage test, yet registers no runtime handler — so it only failed when a user clicked the button (Action '<name>' on object '*' not found).This adds the two layers that would have caught it, per the post-mortem discussion.
① Author/compile-time guard (root cause)
ActionSchemanow enforcesbody || targetwhentype === 'script'via asuperRefine, mirroring the existing "non-script types requiretarget" rule.os build/defineActionreject the broken shape immediately, for every bundle.body-bound actions are auto-registered by the runtime (AppPlugin→actionBodyRunnerFactory).target-bound actions name a function wired imperatively (e.g. viaonEnable, as app-todo does) — the compiler can't see that wiring, sotargetis accepted as the author's assertion that a handler exists.body-less andtarget-less script actions are rejected — those are unambiguously dead.Verified against the full monorepo build (
turbo build, 76 tasks): every shipped bundle still compiles, so this rejects only configurations that were already non-functional at runtime. Spec fixtures that leaned on the looser rule were updated.② Execution-path test (catch-net)
examples/app-showcase/test/actions.test.tsdrives the realactionBodyRunnerFactory+ QuickJS sandbox (the exact bridgeAppPluginuses) against the shipped actions:scriptaction is executable (bodyortarget);{ done: true, progress: 100 }and leavesstatusuntouched;The prior
coverage.test.tsonly asserted eachActionTypeappeared in the bundle — that blind spot is what let #2169 ship.Verification
@objectstack/specfull suite: 6603 tests pass (incl. updated action/stack fixtures).turbo build(whole monorepo): 76 tasks pass — no real bundle violates the new rule.turbo testfor runtime / objectql / downstream-contract / cli / service-ai / service-automation / example-crm / example-todo: all pass.pnpm verify: typecheck + 26 tests (incl. the 4 new execution tests).🤖 Generated with Claude Code