Uh oh!
There was an error while loading. Please reload this page.
chore(deps): upgrade @types/node to ^26.0.0 (+ fix createPublicKey under stricter crypto types) - #2180
Merged
Merged
Conversation
…er stricter crypto types Re-applies the @types/node 25→26 bump (originally #2160; reverted in #2177 to unbreak main). @types/node 26 narrowed `createPublicKey`'s input union to drop `KeyObject`, which broke the publisher self-check in `os plugin sign`: packages/cli/src/commands/plugin/sign.ts: createPublicKey(createPrivateKey(privateKeyPem)) // KeyObject input Derive the public half from the private-key PEM string instead — runtime-identical (verified: same SPKI, signature verifies) and `string` is still an accepted `createPublicKey` input under @types/node 26. Drops the now-unused `createPrivateKey` import. Verified: full workspace build green; @objectstack/cli and @objectstack/core build clean under @types/node 26. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📓 Docs Drift CheckThis PR changes 36 package(s): 105 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Re-applies the
@types/node25→26 upgrade (originally #2160, reverted in #2177 to unbreak CI) together with the code fix that makes it compile.Why it broke before
@types/node26 narrowedcreatePublicKey's input union to dropKeyObject, breaking the publisher self-check inos plugin sign:(
createPublicKey(createPrivateKey(pem))— passing aKeyObject.)Fix
Derive the public half from the private-key PEM string instead of a
KeyObject:createPublicKeyderives the public key from a private-key PEM).stringis still an acceptedcreatePublicKeyinput under @types/node 26 → compiles.createPrivateKeyimport.Verified
pnpm buildgreen under @types/node 26.@objectstack/cli+@objectstack/corebuild clean.@objectstack/coretest suite: 284 passed (incl.plugin-artifact-signature).pnpm install --frozen-lockfileconsistent.🤖 Generated with Claude Code