Uh oh!
There was an error while loading. Please reload this page.
feat(cli): validate all flat record-scoped predicates at build time - #2187
Merged
Conversation
…ADR-0032) Extends the action-predicate guard to the remaining flat record-scoped sites, catching bare field references that silently mis-behave at runtime: - field conditional rules (requiredWhen/readonlyWhen/conditionalRequired/visibleWhen) — fail-open when broken - sharing-rule condition (security: which rows a principal sees) - lifecycle hook condition (skips handler when false) - nested `when` on conditional validation rules formula: add `parent` to record-scope namespace roots — master-detail inline grids inject the header record as `parent` for a child field's readonlyWhen (ADR-0036, #1581), so `parent.status` is legitimate, not a bare ref. Verified: full monorepo build 76 tasks clean (zero false positives across all examples + platform bundles); cli validator suite 25 cases (5 new). Deeply-nested UI visibility (view/page tree, object field-group visibleOn, app-nav) is deferred — it needs a recursive walker + per-node scope rules. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📓 Docs Drift CheckThis PR changes 2 package(s): 18 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to framework#2185 (action predicates). Extends the ADR-0032 build-time check to the remaining flat record-scoped predicate sites — the same "bare field ref silently mis-behaves at runtime" class, in higher-stakes places.
Now validated (record-scoped, bare-ref → build error)
requiredWhen/readonlyWhen/conditionalRequired/visibleWhenobj.fields[]conditionstack.sharingRules[]conditionstack.hooks[]whenonconditionalvalidation rulesobj.validations[](Already covered before this PR: flows, validation-rule predicates, field formulas, action
visible/disabled.)@objectstack/formulaAdds
parentto the record-scope namespace roots. Master-detail inline grids inject the header record asparentfor a child field'sreadonlyWhen/requiredWhen(ADR-0036, #1581) — soparent.status == 'paid'is legitimate, not a bare ref. (Caught as a "false positive" by the first build run; this is the correct resolution.)Verification
turbo build, 76 tasks): clean — zero false positives across every example + platform bundle.record./parent.accepted; sharing bare-ref; hook bare-ref; nestedwhenbare-ref).Deferred (separate follow-up)
Deeply-nested UI visibility predicates —
viewelement/sectionvisibleOn/condition,pagecomponentvisibility, object field-groupvisibleOn, app-navvisible. These need a recursive view/page tree walker plus per-node scope classification (app-nav is user/feature-scoped not record-scoped; object field-groupvisibleOnexamples use bare fields by design). Rushing record-scope onto them would false-positive platform-wide, so they warrant their own design rather than a mechanical add.🤖 Generated with Claude Code