Uh oh!
There was an error while loading. Please reload this page.
fix(ai): keep platform agents in catalog regardless of alias-map timing (ADR-0063 follow-up) - #2192
Closed
xuyushun441-sys wants to merge 2 commits into
Closed
fix(ai): keep platform agents in catalog regardless of alias-map timing (ADR-0063 follow-up)#2192xuyushun441-sys wants to merge 2 commits into
xuyushun441-sys wants to merge 2 commits into
Conversation
…ecouple agent catalog from it Live EE-rig verification of ADR-0063/0064 surfaced two coupled defects in the AI agent catalog/alias layer: 1. GET /api/v1/ai/agents omitted `build` even though build chat worked. 2. POST /api/v1/ai/agents/metadata_assistant/chat 404'd — the legacy alias was dead. Root cause (deeper than the suspected record-init order): `@objectstack/service-ai` ships BOTH an ESM (`import`→index.js) and a CJS (`require`→index.cjs) build, and the alias table was a module-level `new Map()` — so each build got its OWN copy. The cloud AI Studio plugin is bundled as CJS and `require`s the CJS copy to register `metadata_assistant`→`build`, while the framework agent routes load as ESM and read the ESM copy — the alias was written to a Map nobody read. - agent-aliases: anchor the registry (and its `data_chat`→`ask` seed) on a `Symbol.for` key on globalThis so the ESM and CJS builds share ONE table. - agent-runtime.listAgents: stop keying catalog membership solely on the in-memory alias-table values. Decide membership from an INTRINSIC, persisted package signal (`_provenance:'package'`/`_lock`, or a pre-translation `protection` block), with the alias values kept as a fallback union. A missed alias must never hide a real platform agent (ADR-0063 §2 still hides stray tenant agents). - ask-agent: carry a package `protection` block (lock:'full'); translate it to the runtime `_lock`/`_provenance` envelope at register via applyProtection so the catalog signal is present and the built-in persona is locked against overlay edits. Tests: globalThis-shared registry; listAgents surfaces a platform agent via the intrinsic signal with NO alias registered, and still hides an envelope-less tenant agent. Full service-ai suite green (409). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📓 Docs Drift CheckNo hand-written docs reference the 0 changed package(s). ✅ |
xuyushun441-sys
commented
Jun 22, 2026
ContributorAuthor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2181 (ADR-0063/0064). Found during live verification on the EE rig:
GET /api/v1/ai/agentsreturned only{ask}— thebuildagent was missing — becauselistAgents()filtered the catalog by the in-memoryregisterAgentAliasvalues, and the cloud studio package'smetadata_assistant→buildalias wasn't applied to the runtime's map at request time (bundle module-load ordering). A missed alias must never hide a real platform agent.Change
listAgents()recognises a platform agent by the intrinsic package-protection envelope stamped on built-ins at registration (_provenance/_lock/_packageId, or a still-publicprotectionblock) viaisPlatformAgentRecord(...), with the alias-table values kept only as a belt-and-suspenders fallback.Pairs with cloud-side robustness for the studio alias registration (objectstack-ai/cloud#419).
Verified on the EE rig after the fix; no spec/schema change (no liveness impact).
🤖 Generated with Claude Code