Uh oh!
There was an error while loading. Please reload this page.
feat(datasource): fail-closed credential resolution at connect (ADR-0062 Phase 2, D3) - #2199
Merged
Merged
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📓 Docs Drift CheckThis PR changes 6 package(s): 101 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
…062 Phase 2, D3) A declared external.credentialsRef MUST resolve to a cleartext secret before the driver is built — an absent secret store or an unresolvable/undecryptable ref now fails closed (clear message, datasource left unconnected) instead of silently building a driver without the credential. Follows the same fail-fast (declared external + onMismatch:fail) vs degrade policy as connect failures. Converges with the runtime-admin secret path (same SecretBinder threaded through the shared connection service). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
xuyushun441-sysforce-pushed
the
feat/adr-0062-credentials-p2
branch
from
June 22, 2026 12:18
688a28b to
9911bc2Compare…able (ADR-0062 Phase 3, D6) (#2200)
Deployment failed with the following error: View Documentation: https://vercel.com/docs/accounts/team-members-and-roles |
… onEnable bridge (ADR-0062 Phase 4, D7/D8) (#2203)
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADR-0062 Phase 2 — credentials at connect (D3)
Stacked on #2198 (Phase 1) — review/merge that first; this PR's base is the Phase 1 branch, so its diff is only the Phase 2 delta.
Makes credential resolution in
DatasourceConnectionServicefail-closed. Phase 1 already wired thecredentialsRef→SecretBinder.resolvehook (happy path); this PR adds the safety semantics the ADR requires:external.credentialsRefmust resolve to a cleartext secret before the driver is built. An absent secret store, an unresolvable/undecryptable ref (missingsys_secretrow, rotated key), or a throwing resolver now leaves the datasource unconnected with a clear message — never a silent build-without-secret (which would connect with no/wrong auth, or fail later with a confusing driver error).external+onMismatch:'fail'auto-connected at boot bricks boot; runtime-admin create/update + rehydration degrade-with-warning — a UI action never bricks the server).SecretBinderthreaded through the one shared connection service. Open-core default crypto provider is unchanged (serve.ts already wires one).failed-credentialsconnect status.Tests
failunresolvable → re-throws, resolves → connected with secret. (service-datasource85 total.)credentialsRef+onMismatch:'fail'bricks boot with a clear message end-to-end throughAppPlugin. (runtimedatasource-autoconnect 6 total.)Closes (partially) #2163 — Phase 2.
🤖 Generated with Claude Code