Uh oh!
There was an error while loading. Please reload this page.
feat(runtime): add GET /ready readiness probe for graceful rolling restarts - #2217
Merged
Conversation
…starts The dispatcher exposed only /health (always 200). Multi-replica deployments need a readiness signal so a load balancer drains a replica before its in-flight requests are force-closed on shutdown. /ready returns 200 only when the kernel state is 'running'; 503 while booting (idle/initializing) or shutting down (stopping/stopped). Added to the membership-skip paths like /health so it is reachable without auth/environment scoping. Pairs with the existing in-flight drain in HonoHttpServer.close() (P1-3). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 17 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
Uh oh!
There was an error while loading. Please reload this page.
os-zhuang added a commit
that referenced
this pull request
Jul 16, 2026
…the handler (#2995) handlePackages has handled `PATCH /packages/:id` (edit a package's name / description / version) all along, but the route was never mounted in dispatcher-plugin — only GET/DELETE `/:id` and PATCH `/:id/enable|disable` were. So `PATCH /packages/:id` 405'd over HTTP and the Studio "edit package" form silently failed (surfaced dogfooding the builder header refresh). Register the missing route, mirroring the GET/DELETE `/:id` handlers. `/:id` is a single path segment, so it does not shadow the `/:id/enable|disable` routes. Adds a route-registration regression test (same class as the /ready seam bug, #2217). Co-authored-by: Jack Zhuang <277994282+os-zhuang@users.noreply.github.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The dispatcher exposed only
/health(always 200). Multi-replica deployments need a readiness signal distinct from liveness: a load balancer must stop routing to a replica before its in-flight requests are force-closed on shutdown, and must not route to a replica that is still booting.What
GET /ready→ 200 only whenkernel.getState() === 'running'; 503 while booting (idle/initializing) or shutting down (stopping/stopped)./readyto the membership-skip paths (like/health) so it's reachable without auth/environment scoping.HonoHttpServer.close()(P1-3):/ready503 → LB drains → in-flight finish → close.@objectstack/runtime+ tests green.Scope
Generic open-core production-hygiene mechanism (benefits any deployment, single- or multi-node). No cluster dependency. Part of the multi-node readiness groundwork (cloud ADR-0018).
🤖 Generated with Claude Code