Uh oh!
There was an error while loading. Please reload this page.
feat(spec): type ChartConfig colors as palette or value→color map - #2262
Merged
Conversation
ChartConfigSchema.colors now accepts a positional palette (string[]) OR an explicit value→color map (Record<value,color>, kanban-style). A value→color map — and a select/lookup dimension's option colors — take precedence over the positional palette per category. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Uh oh!
There was an error while loading. Please reload this page.
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 91 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Types
ChartConfigSchema.colorsas a union: either a positional palette (string[]) or an explicit value→color map (Record<value, color>, kanban-style — mirroringRowColorConfigSchema.colors).Why
Spec-level parity for the
object-chartsemantic-color feature shipped in objectui (objectstack-ai/objectui#1932 renderer + #1936ObjectChartSchematyping). When a chart's category dimension is a select/lookup field, its option colors — and any explicit value→color map — should take precedence over the positional palette per category, so health/status charts paint their own semantic colors instead of the generic--chart-1..5palette.Additive and backward-compatible: the field is optional and the existing
string[]palette form is unchanged. No framework runtime consumesChartConfig.colorsas an array, so the union widens the type with no break.🤖 Generated with Claude Code