Uh oh!
There was an error while loading. Please reload this page.
feat(spec): add back edge style to the flow-builder canvas protocol - #2291
Merged
Conversation
…ocol `FlowCanvasEdgeStyleSchema` gains a `back` value alongside solid/dashed/dotted/bold, marking an ADR-0044 declared back-edge (a `revise` loop's resubmit edge). Flow-builder-protocol consumers can render it as a distinct curved/dashed return arc, set apart from forward flow — matching the objectui designer's canvas (objectstack-ai/objectui#1954). Additive enum value: public API surface + factory signatures unchanged. Part of #2274 (ADR-0044 AI/designer parity). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 91 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
Uh oh!
There was an error while loading. Please reload this page.
os-zhuang added a commit
that referenced
this pull request
Jun 24, 2026
…vision shape (#2294) The objectstack-automation skill documented approve/reject approvals (ADR-0019) but not the ADR-0044 revise loop, so AI-authored approval flows omit it (and a revise loop hand-built without the back-edge gets rejected by registerFlow). Add a "Send-back for revision" section to the Approvals area: the `revise` out-edge → a signal `wait` node, the resubmit edge typed `type: 'back'` (the only thing that legalizes the cycle — graph-minus-back-edges must be a DAG, authors opt in edge by edge), and the `maxRevisions` budget. Calls out the two shapes the compile-time flow lint flags (dead-end revise; unmarked back-edge) and points at the canonical showcase_budget_approval. Completes the agent-teaching slice of #2274 (ADR-0044), alongside the compile-time lint (#2279), the flow-builder `back` edge style (#2291), and the engine's already-specific cycle-rejection hint. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2274 (#2274 item 3 — spec completeness).
FlowCanvasEdgeStyleSchemagains abackvalue alongsidesolid/dashed/dotted/bold, marking an ADR-0044 declared back-edge (areviseloop's resubmit edge) so flow-builder-protocol consumers render it as a distinct curved/dashed return arc — matching the objectui designer's hand-rolled canvas (objectui#1954).Additive enum value —
check:api-surfaceconfirms the public API surface + factory signatures are unchanged.Verification:
@objectstack/specflow-builder tests 23 passing (acceptsback);tsc --noEmitclean; spec build green; api-surface check ✓.Refs #2274, #1770 (ADR-0044). 🤖 Generated with Claude Code