Uh oh!
There was an error while loading. Please reload this page.
chore(showcase): remove the AI agent (service-ai is an enterprise capability) - #2317
Merged
Conversation
fix(console): gate the AI surface on the service-ai capability, not the agent catalog (#1992) objectui@8a3b351a5a320e6769a1616e85a6fd05aabd3279
…pability The showcase defined a `showcase_assistant` agent + a skill + two tools, all of which need the enterprise `@objectstack/service-ai` runtime to be served. The open-source showcase shouldn't require an enterprise capability, so drop the AI block entirely: - delete `src/agents/index.ts` (agent + skill + tools) and its config wiring (`agents` / `skills` / `tools`); - remove the `@objectstack/service-ai` dependency (added in #2311 to back the agent — no longer needed); - drop the descriptive `ai` entry from the coverage map and update the seed test (`agents.length` 1 → 0). The showcase now boots as a Community-Edition shape: no AI service is registered, discovery reports `services.ai` unavailable, and `/api/v1/ai/agents` 404s — so the console hides its AI surface. `tsc --noEmit` + all 39 showcase tests pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Uh oh!
There was an error while loading. Please reload this page.
os-zhuang added a commit
that referenced
this pull request
Jun 25, 2026
…ity (#2319) Mirror the showcase change (#2317): the open-source CRM example shouldn't define an AI agent that requires the enterprise @objectstack/service-ai runtime. - delete src/agents/ (SalesAssistantAgent + DealManagementSkill + LookupContactTool) and its config wiring (agents / skills) plus the unused referenceMetadata export; - remove the @objectstack/service-ai dependency (added in #2311 to back the agent). crm now boots as a Community-Edition shape: no AI service registered, discovery reports services.ai unavailable, /api/v1/ai/agents 404. tsc --noEmit + all 29 crm tests pass. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Follow-up to #2311 and objectui's service-ai gating.
@objectstack/service-aiis an enterprise capability; the open-source showcase shouldn't define an AI agent that requires it.The showcase shipped a
showcase_assistantagent + a skill + two tools, served by the (enterprise)service-airuntime. In #2311 I added a@objectstack/service-aidependency to the showcase to keep that working — but per the edition model, the open showcase should be Community-Edition-shaped: no AI.What
src/agents/index.ts(agent + skill + tools) and remove theagents/skills/toolswiring fromobjectstack.config.ts.@objectstack/service-aidependency (reverts feat(cli): make the AI service opt-in via a declared dependency (Community-Edition support) #2311's showcase addition).aientry fromsrc/coverage.ts(capabilityChains) and updatetest/seed.test.ts(agents.length1→0).The enum-coverage test (
coverage.test.ts) only asserts field/view/chart/report/action types — unaffected.Verification (worktree, fresh runtime)
tsc --noEmitclean; all 39 showcase tests pass (incl.seed.test.tsandcoverage.test.ts).services.ai: { enabled: false, status: "unavailable" },/api/v1/ai/agents→404, AIService not in the plugin list → the console hides its AI surface.🤖 Generated with Claude Code