Uh oh!
There was an error while loading. Please reload this page.
feat(automation)!: remove deprecated http_request/http_call/webhook flow-node aliases (ADR-0018 M3, 11.0) - #2369
Merged
Merged
Conversation
…low-node aliases (ADR-0018 M3, 11.0) ADR-0018 M3 collapsed the divergent outbound-callout verbs onto the canonical `http` node and kept the old names as deprecated aliases for back-compat. This removes them as part of the 11.0 breaking-change batch. - spec: drop `http_request` from `FlowNodeAction` (so it leaves `FLOW_BUILTIN_NODE_TYPES`); the flow-builder palette offers `http`; BPMN serviceTask maps to `http`. - service-automation: `registerHttpNodes` no longer registers the `http_request` / `http_call` / `webhook` aliases — only the canonical `http`. - examples (showcase, app-crm): migrated to `type: 'http'`. - tests updated; http-nodes gains a guard asserting the aliases are NOT registered. The trigger `eventType: 'webhook'` / `webhook` resume event are untouched — only the HTTP *node* aliases are removed. Authoring a removed type now fails fast at parse instead of silently resolving. Verified: spec (154) + service-automation (111) tests green; showcase + app-crm build clean (flows validate as `http`). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub.
|
25 tasks
Contributor
📓 Docs Drift CheckThis PR changes 2 package(s): 93 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the deprecated
http_request/http_call/webhookflow-node aliases, leaving the canonicalhttpnode as the only outbound-callout verb. Part of the 11.0 breaking-change batch (epic #2364, A3).ADR-0018 M3 collapsed the divergent verbs onto
httpand kept the old names as deprecated aliases for back-compat. 11.0 is where they're removed.Changes
http_requestfromFlowNodeAction(so it leavesFLOW_BUILTIN_NODE_TYPES = FlowNodeAction.options); flow-builder palette offershttp; BPMNserviceTask↔http.registerHttpNodesno longer registers thehttp_request/http_call/webhookaliases — only canonicalhttp. (registerNodeAliasitself stays — general capability.)type: 'http'.http-nodes.test.tsgains a guard asserting the removed aliases are not registered.Not touched (deliberately)
eventType: 'webhook'and thewebhookresume event — different namespace, unaffected.http_requests_total, …) and arbitrary node-ids (http_call_1).AutomationEngine.registerNodeAlias— kept as a general aliasing capability.Behavior change
Authoring a removed node type now fails fast at parse instead of silently resolving to
http. Migration is mechanical:type: 'http_request'→type: 'http'(identical runtime — durable outbox whenconfig.durable, inline fetch otherwise). Pre-launch, so only first-party examples needed migrating.Verification
@objectstack/spectests: 154 passed (flow / execution / bpmn-interop / bpmn-mapping / node-executor / flow-builder).@objectstack/service-automationtests: 111 passed; engine boots 17 node types withhttp, no aliases.example-showcase+example-crmbuild clean (flows validate ashttp).changeset status→ major; fixed-group check passes.Rides into 11.0 alongside #2366.
🤖 Generated with Claude Code