Uh oh!
There was an error while loading. Please reload this page.
feat(lint,cli): os build gate for kind:'jsx' page source (ADR-0080 M3b②) - #2440
Merged
Conversation
… M3b②) New validateJsxPages lint rule parses a jsx page's source via @objectstack/sdui-parser and surfaces parse/structural/forbidden-construct errors at author time (loud-not-silent, ADR-0078). Wired into os validate (and os build) alongside the expression/widget/style gates. Parse-level until the registry manifest is threaded through for full prop validation. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📓 Docs Drift CheckThis PR changes 2 package(s): 15 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADR-0080 M3b② — the author-time gate.
os validate/os buildnow parse akind:'jsx'page'ssourcevia@objectstack/sdui-parser(newvalidateJsxPageslint rule), so malformed JSX fails loudly at author time (ADR-0078) instead of being stored and only breaking at render — alongside the existing expression / widget / styling gates.Scope: parse-level — syntax, tag matching, forbidden constructs (event handlers,
dangerouslySetInnerHTML). Full component/prop whitelist validation arrives once the registry manifest is threaded throughcompile()(the cross-repo manifest-artifact pipeline — the remaining M3b piece). This also makes@objectstack/sdui-parsera consumed (non-inert) package.Verified:
validateJsxPagesunit checks (valid passes; empty/malformed/forbidden flagged at thesourcepath; non-jsx ignored). Lockfile + changeset included;@objectstack/lintgains a@objectstack/sdui-parserdep.Still remaining (true M3b tail, needs cross-repo infra): ship a serialized component manifest to the gate for full prop validation, and have
@object-ui/sdui-parserre-export this package once published.🤖 Generated with Claude Code