Uh oh!
There was an error while loading. Please reload this page.
docs(adr-0086): re-evaluate authz metadata/config boundary against latest code (#2557) - #3011
Merged
Merged
Conversation
…test code (#2557) ADR-0086 was written the day #2557 opened; its full plan has since shipped and three later ADRs (0090, 0094, 0095) built on it. Flip status Proposed → Accepted (substantially implemented) and add a code-grounded Re-evaluation (2026-07-16) addendum: - Per-decision/phase status table (D1-D7, P0-P2) with file-level landing points: D3 packageId+provenance, D5 bootstrapDeclaredPermissions, P0 objectui slice-merge (#2505/#2508), D6/D7 two doors — all implemented. - Flag the two mechanisms the original text describes that later work overtook: P0's shared-data-record slice-merge premise -> ADR-0094 pure projection + metadata overlay; D4's Salesforce-muting subtract layer -> ADR-0005 first-class overlay (ADR-0094 D5 revised). - Restate the D1 classification table in current ADR-0090 vocabulary: Position (not Role, flat/no parent), Profile removed, everyone/guest anchors, renamed + time-boxed (ADR-0091) assignment tables, adminScope (ADR-0090 D12). - Net: no decision reversed; thesis holds. Remaining open items are the ones already marked deferred/evidence-gated.
The latest updates on your projects. Learn more about Vercel for GitHub.
|
4 tasks
os-zhuang
marked this pull request as ready for review
July 16, 2026 04:57
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-evaluates the ADR-0086 design (authz metadata↔config boundary + cross-package composition, the deliverable of #2557) against the current code (HEAD 2026-07-16). The ADR was written the day #2557 opened (2026-07-04); its full plan has since shipped, and three later ADRs built directly on it. This PR flips the ADR's status from Proposed → Accepted (substantially implemented) and appends a code-grounded Re-evaluation (2026-07-16) addendum.
What the re-evaluation found
The central thesis holds unchanged — definitions travel with the package (provenance
managedBy+packageId); subject bindings stay environment config; cross-package grants compose conflict-free by the namespaced-key UNION. Every decision and phase has landed:packageId+ provenance on the setspec/security/permission.zod.ts:167,178;sys-permission-set.object.ts:217-266bootstrapDeclaredPermissionsplugin-security/src/bootstrap-declared-permissions.ts(seedsmanaged_by:'package'+package_id; closes the ADR-0078 inert-metadata smell)permission-slice.ts+mergePermissionSlice; packageId-scoped matrix; draft-mode savemode:'draft'; env door live + ADR-0094 write-throughTwo mechanisms overtaken by better realizations (flagged inline)
sys_permission_setis now a derived projection over the metadata layer; the data-loss trap is closed structurally (no second writable authority). The inlineobjects/fieldsbody shape survived, so the namespaced-key slice invariant still holds.Vocabulary refresh (ADR-0090)
The D1 classification table is restated in current vocabulary: Position (not Role; flat, no
parent), Profile removed,everyone/guestanchors replacing themember_defaultfallback, renamed + time-boxed (ADR-0091) assignment tables, and the ADR-0090 D12adminScope.Net
No decision was reversed. Remaining genuinely-open items are the ones the ADR already marked deferred and evidence-gated (ADR-0066 explicit-deny precedence layer, permission-set groups, OWD env-tightening via overlay).
Changes
docs/adr/0086-authz-metadata-config-boundary-and-cross-package-composition.md— status line + Re-evaluation (2026-07-16) addendum. Docs-only; no code or behavior change.Closes the re-evaluation ask on #2557.
🤖 Generated with Claude Code
Generated by Claude Code