Uh oh!
There was an error while loading. Please reload this page.
docs(spec): retire stale renderViaSchema comment + browser-verify ADR-0085 detail shapes (#2548) - #3019
Merged
Merged
Conversation
…verify ADR-0085 detail shapes (#2548) Follow-up to objectui#2546 (ADR-0085 PR4), which removed the legacy monolith detail renderer and the `detail.renderViaSchema` kill-switch and flagged two follow-ups for #2548: - Comment cleanup: the ObjectSchema source comment forward-referenced `renderViaSchema` retiring "together with the legacy monolith render path". That path is now gone; the comment records the completed state with a breadcrumb to objectui#2546. Comment-only — no type/runtime change. - Real-backend browser verification: drove the running app-showcase backend plus the objectui Console (post-#2546 source) in a headless browser across the four detail-page shapes (grouped / ungrouped / stageField:false / related-heavy). All render correctly through the single SchemaRenderer path, and stageField:false correctly suppresses the record:path stepper. Results + repro runbook in docs/audits/2026-07-adr-0085-detail-shapes-browser-verify.md. No regressions; no objectui follow-up required. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016wpaFMPowSn4nAWsjeGZib
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 97 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
os-zhuang
marked this pull request as ready for review
July 16, 2026 05:09
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Closes the two items objectui#2546 (ADR-0085 PR4) deferred to #2548, now that it has merged:
Framework
renderViaSchemacomment cleanup. TheObjectSchemasource comment forward-referencedrenderViaSchemaretiring "together with the legacy monolith render path" — a promise about work not yet shipped. objectui#2546 removed that path and thedetail.renderViaSchemakill-switch that was its only steering wheel, so the comment now records the completed state with a breadcrumb to that PR instead of a forward reference. Comment-only — no type, schema, or runtime change.Real-backend browser verification of the four detail-page shapes. objectui#2546 could not run this ("needs a running
@objectstackbackend, which the CI/agent environment doesn't have"). This PR performs it and lands a repro runbook + results as a dogfood audit note.Verification (real backend + real browser)
Booted the
app-showcasebackend and pointed the objectui Console (post-#2546 source, so the schema-only path) at it, then drove record detail pages in headless Chromium.RecordDetailViewnow has a single path — authoredPageSchema(pageType='record')when assigned, elsebuildDefaultPageSchema()synthesis, both via<SchemaRenderer>.showcase_semantic_zooname / Active / 4,200) + Draft → Active → Donerecord:pathfromstageField:'status'✅showcase_account· Detailsshowcase_semantic_zoo_legacystatusrenders as an ordinary field, norecord:pathstepper —falsecorrectly suppresses the heuristic ✅showcase_account(Contoso)hasRecordPathmatched expectation for every case (true for grouped + related-heavy, false for stageField:false). No render errors, error boundaries, or missing-data states. No regressions found; no objectui follow-up required. The full repro runbook, per-shape observations, and out-of-scope notes (split-origin harness502s on/runtime/config+/dev/metadata-events; a peripheral approvals-badge401) are indocs/audits/2026-07-adr-0085-detail-shapes-browser-verify.md.Changes
packages/spec/src/data/object.zod.ts— rewrite the stalerenderViaSchemaforward-reference into a completed-state note with anobjectui#2546breadcrumb.docs/audits/2026-07-adr-0085-detail-shapes-browser-verify.md— new dogfood audit: repro runbook + four-shape results..changeset/adr-0085-pr4-renderviaschema-comment-2548.md—@objectstack/specpatch (docs(spec)).Scope notes
docs/audits/2026-06-objectschema-property-liveness.mdstill listsdetail.renderViaSchema— left as-is; it is a point-in-time snapshot (2026-06-15), not a living ledger.object.test.ts's strip test usesdetail: { renderViaSchema: false }as a realistic legacy payload — kept as valid coverage of the strip behavior, not a stale comment.🤖 Generated with Claude Code
https://claude.ai/code/session_016wpaFMPowSn4nAWsjeGZib
Generated by Claude Code