Uh oh!
There was an error while loading. Please reload this page.
fix(vscode): drop invalid ownership: 'own' from object snippet; document the field (#3175) - #3193
Merged
Merged
Conversation
… document the field (#3175) Follow-up to #3185. The VS Code `os-object` snippet still scaffolded `ownership: 'own'` — the same now-invalid value removed from the CLI `generate` scaffold. Since #3185 made `ownership` a typed `'user' | 'org' | 'none'` enum, expanding the snippet produced an object that fails typecheck / `ObjectSchema.create()`. - vscode: remove the `ownership: 'own'` line from the object snippet (owner injection is the default; nothing to declare). - docs: document the now first-class `ownership` record-ownership knob in the object Additional Properties table. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014343Qv6DFAykuAJc9yjANb
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 1 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
os-zhuang
marked this pull request as ready for review
July 18, 2026 07:31
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Follow-up to #3185 (#3175). That PR made
ownershipa typed'user' | 'org' | 'none'enum and removed the now-invalidownership: 'own'from the CLIgeneratescaffold — but the VS Codeos-objectsnippet carried the same value and was missed. Expanding the snippet produced an object that fails typecheck /ObjectSchema.create()with the new enum.Changes
ownership: 'own'line from theos-objectsnippet (owner injection is the default; nothing to declare). This was the last authorable surface still emitting the invalid value — a repo sweep confirms none remain outside historical CHANGELOG entries and the unrelated package-contribution (own/extend) records.ownershiprecord-ownership knob in the object Additional Properties table (content/docs/data-modeling/objects.mdx). The generated reference (object.mdx) was already updated in fix(spec): declareownershipas a first-class ObjectSchema field (#3175) #3185; no other hand-written doc referenced the field, so nothing else needed correcting.No library/runtime change — a tooling snippet fix plus a docs row.
🤖 Generated with Claude Code
https://claude.ai/code/session_014343Qv6DFAykuAJc9yjANb
Generated by Claude Code