Uh oh!
There was an error while loading. Please reload this page.
chore(lint): org-identifier authoring guard for deprecated session.tenantId (#3280 follow-up) - #3289
Merged
Merged
Conversation
…n.tenantId (#3280 follow-up) `organizationId` is the blessed developer-facing name for the caller's active org in hook/action bodies (#3280); `ctx.session.tenantId` is a deprecated alias. TSDoc `@deprecated` only nudges an author whose editor surfaces it — nothing stopped our own reference apps (examples/, apps/), which authors and AIs copy from, re-introducing `session.tenantId`. scripts/check-org-identifier.mjs is a hard-fail guard (authoring surfaces carry zero occurrences today) wired into the lint workflow. Deliberately narrow: - scans author-facing reference code only (examples/, apps/) — internal packages legitimately read `session.tenantId` (driver-layer alias, a #3280 non-goal); - excludes skills/ + content/docs/, which teach the deprecated form on purpose; - matches only the `session.tenantId` token, never `execCtx.tenantId` / `opts.tenantId` / `DriverOptions.tenantId` (the generic tenancy knob); - escape hatch: `os-allow-tenant-id` comment on the line. Proven red on a new occurrence, green when reverted, suppressed by the marker. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub.
|
4 tasks
Uh oh!
There was an error while loading. Please reload this page.
4 tasks
This was referenced Aug 6, 2026
This was referenced Aug 6, 2026
lemonhub-io pushed a commit
to OpenFork-org/objectstack
that referenced
this pull request
Aug 8, 2026
…退 1 留 (objectstack-ai#5055) (objectstack-ai#6385) * refactor(spec)!: retire the widget-registration + doorless i18n vocabularies, keep FieldWidgetProps (objectstack-ai#5055) ADR-0049 enforce-or-remove for the 14 sites objectstack-ai#4001 批 16 measured as `no door`. Disposed per site against a re-measurement on origin/main: 13 REMOVED, 1 KEPT. Removed — 10 defs, 26 exported names: ui/widget.zod.ts WidgetManifest, WidgetLifecycle, WidgetEvent, WidgetProperty, WidgetSource (npm/remote/inline union) ui/i18n.zod.ts I18nObject, PluralRule, NumberFormat, DateFormat, LocaleConfig None had a carrier key: nothing under packages/spec/src imported widget.zod at all, every live import of i18n.zod names I18nLabelSchema or AriaPropsSchema, the BFS from all 24 metadata-type roots plus defineStack reached none of them (with PageSchema / ObjectListViewSchema resolving `direct` in the same run and a synthetic carrier flipping all of them), and no repo ever parsed one. So a published vocabulary described a widget-registration and locale-formatting capability the platform does not have — the objectstack-ai#3950 shape. Kept — FieldWidgetProps. Its evidence differs and had been overtaken one day before 批 16 measured. It is a React props contract, never authorable (absent from authorable-surface/ and json-schema.manifest/ — onChange is a z.function()), so having no parse is its design; and objectui PR objectstack-ai#3289 (2026-08-03) renamed @object-ui/fields' validation slot onto its `error` with no alias and pinned it as a deliberate compile-time tripwire. Re-verified on objectui origin/main. Route 3 ("nothing parses it → neither"), as objectstack-ai#4988 / objectstack-ai#4834: no retiredKey() tombstone and no D2 conversion, because there is no shape to tombstone and no source to rewrite. The declared record is the D3 SemanticMigration ui-widget-i18n-family-retired plus 10 RETIRED_DEFS_BY_MAJOR entries, which the objectstack-ai#4725 manifest-deletion gate reads. WidgetManifest.performance's own tombstone (objectstack-ai#3896) is subsumed by the removal of the shape that carried it. Baselines moved deliberately: json-schema.manifest/ui.json -10 (the objectstack-ai#2978 ratchet fires first), authorable-surface/ui.json -65 (adjudicated by the objectstack-ai#4650 gate's path 3), api-surface/ui.json -26. variant-docs.json's `type:inline|npm|remote` entry goes with the union it described (objectstack-ai#5552's failure mode). Reference docs, meta.json, skill indexes and the strictness-ledger counts regenerated; the `no door` bucket goes 14 -> 1. Pins are bidirectional: ui/widget-i18n-retirement.test.ts asserts absence across every public entry by resolved symbol identity AND the survival of the three shapes a too-wide sweep would take — FieldWidgetProps, AriaProps and I18nLabel, all three of which live in the two files being emptied. The objectstack-ai#5056 clone-overlap fixture is rebuilt locally so the instrument's measured 2-of-19 bound survives its subject. No runtime behaviour changes; that impossibility is the reason for the removal. Refs objectstack-ai#5055, objectstack-ai#4001, objectstack-ai#4988, ADR-0049, ADR-0087 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XUAV11R31jhzq6v1wb6SuJ * chore(changeset): declare the ADR-0087 disposition on the objectstack-ai#5055 retirement (objectstack-ai#6148) The new objectstack-ai#6148 gate requires every changeset that declares a breaking change to answer the ledger question in writing. This one's answer is the first of the four accepted forms — the entry exists: the retirement is registered as the D3 SemanticMigration `ui-widget-i18n-family-retired` in packages/spec/src/migrations/registry.ts, alongside its ten RETIRED_DEFS_BY_MAJOR entries. Comment-only; no schema, artifact or test is affected. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XUAV11R31jhzq6v1wb6SuJ --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3280 (merged in #3284) and #3288. Makes the
session.tenantIddeprecation discoverable at build time for our own reference apps.Why
#3280 made
organizationIdthe blessed developer-facing name for the caller's active org in hook/action bodies;ctx.session.tenantIdis now a deprecated alias. TSDoc@deprecatedonly nudges an author whose editor surfaces it — nothing stopped our own reference apps (examples/,apps/), which authors and AIs copy from, from re-introducingsession.tenantId.What
scripts/check-org-identifier.mjs— a hard-fail guard (authoring surfaces carry zero occurrences today, so any match is new), wired into thelintworkflow next tocheck:nul-bytes/check:role-word. Deliberately narrow:examples/,apps/). Internal framework packages legitimately readsession.tenantId(the engine's ownbuildSession, the record-change trigger) — that's the driver-layer alias, a Unify the developer-facing org identifier: hooks exposesession.tenantIdwhile RLS/seed/columns useorganizationId(addorganizationIdas the blessed name) #3280non-goal, and is not flagged.skills/+content/docs/: they deliberately show the deprecated form when teaching the deprecation.session.tenantIdtoken, neverexecCtx.tenantId/opts.tenantId/DriverOptions.tenantId(the generic driver-layer tenancy knob, explicitly out of scope).os-allow-tenant-idcomment on the line, for a genuine driver-layer use in an example.Proven red (防假绿)
ctx.session.tenantIdinto a tracked example hook → guard fails (exit 1, points toorganizationId).os-allow-tenant-id→ suppressed.check:nul-bytes); ESLint clean.Tooling-only (no package touched) → no changeset needed.
🤖 Generated with Claude Code