Uh oh!
There was an error while loading. Please reload this page.
chore(spec): regenerate stale ADR-0087 artifacts (spec-changes.json + upgrade guide) - #3330
Merged
Merged
Conversation
`spec-changes.json` is a generated artifact (ADR-0087 D4) — a pure projection of the D2 conversion table + D3 migration chain, enforced in CI by `check:spec-changes` (the "Check Generated Artifacts" gate). The committed manifest went stale on `main`: the dashboard-widget `.strict()` migration (`dashboard-widget-strict-unknown-keys`, changeset `dashboard-widget-strict-3251`) landed and moved the protocol major to 16, but the manifest was never regenerated. As a result `check:spec-changes` fails on every open PR, not just this one. Regenerated with `pnpm --filter @objectstack/spec gen:spec-changes`. Pure re-projection of already-merged registries — no source or behaviour change: - protocolVersion 15.0.0 → 16.0.0 - aggregate to: 15 → 16 - new 15→16 migrated record: dashboard-widget-strict-unknown-keys No new changeset: the underlying migration already shipped its own (`dashboard-widget-strict-3251`); this is a generated-artifact re-sync only. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011iJLjqToxNv1aYP3syQtRp
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 104 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
…try updates Second generated artifact stale from the same ADR-0087 registry change as the `spec-changes.json` re-sync in this PR. The "Check Generated Artifacts" job runs `check:spec-changes` then `check:upgrade-guide`; with the manifest fixed, the upgrade guide surfaced as the next stale projection (the job had been failing fast on the manifest before). Regenerated with `pnpm --filter @objectstack/spec gen:upgrade-guide`. Pure re-projection of already-merged registries — no source change: - Current protocol 15.0.0 → 16.0.0 - new "Protocol 15 → 16" section: dashboard-widget-strict-unknown-keys `check:skill-docs`, `check:spec-changes`, and `check:upgrade-guide` all pass locally. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011iJLjqToxNv1aYP3syQtRp
os-zhuang
marked this pull request as ready for review
July 20, 2026 02:33
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two generated ADR-0087 artifacts went stale on
main— never regenerated when the protocol moved to major 16 (the dashboard-widget.strict()migration,dashboard-widget-strict-unknown-keys, changesetdashboard-widget-strict-3251). Both are enforced by the Check Generated Artifacts CI job, so it fails on every open PR — amain-health issue surfaced while validating the ADR-0102 sandbox work (#3275 / #3328).Stale artifacts (both pure projections of the ADR-0087 registries)
packages/spec/spec-changes.json— the machine-readable change manifest (ADR-0087 D4) ·check:spec-changesdocs/protocol-upgrade-guide.md— the human upgrade guide ·check:upgrade-guide(the job fails fast on Add metamodel interfaces for ObjectQL/ObjectUI contract #1, so this only surfaced once Add metamodel interfaces for ObjectQL/ObjectUI contract #1 was fixed)Fix
Regenerated both with the committed generators — pure re-projection of already-merged registries, no source or behaviour change:
pnpm --filter @objectstack/spec gen:spec-changes→protocolVersion15.0.0 → 16.0.0; aggregateto15 → 16; new 15→16migratedrecordpnpm --filter @objectstack/spec gen:upgrade-guide→ current protocol 15.0.0 → 16.0.0; new "Protocol 15 → 16" sectionAll three checks in the job (
check:skill-docs,check:spec-changes,check:upgrade-guide) pass locally.Notes
dashboard-widget-strict-3251); this is a generated-artifact re-sync only.allow-majorbypasses the unrelated pre-existing@objectstack/console: majorchangeset already onmain.🤖 Generated with Claude Code
https://claude.ai/code/session_011iJLjqToxNv1aYP3syQtRp