Skip to content

fix(create-objectstack): exclude CHANGELOG.md from the skills-catalog-boundary ratchet (unblocks main Test Core) - #3346

Merged
os-zhuang merged 1 commit into
mainfrom
fix/skills-guard-exclude-changelog
Jul 20, 2026
Merged

fix(create-objectstack): exclude CHANGELOG.md from the skills-catalog-boundary ratchet (unblocks main Test Core)#3346
os-zhuang merged 1 commit into
mainfrom
fix/skills-guard-exclude-changelog

Conversation

@os-zhuang

Copy link
Copy Markdown
Contributor

Problem — Test Core is red on main

The required Test Core gate has been failing on main since before the current head (first seen at e412fb676 / 631debac5; last green 629fbae80). One test fails:

create-objectstack › template-consistency.test.ts › skills catalog boundary › no customer-facing surface advertises a repo-root skills install

Root cause

The guard greps content/docs / skills / packages/create-objectstack for skills add objectstack-ai/frameworknot followed by /skills, excluding only the test file — not CHANGELOG.md.

When Changesets versioned create-objectstack in RC mode, it baked #3101's changeset prose into packages/create-objectstack/CHANGELOG.md:99. That entry documents the fix by quoting the removed command in past tense:

"…the scaffolder (and the docs) advertised npx skills add objectstack-ai/framework --all … All install commands are now scoped to the published catalog via the /skills subpath…"

The ratchet flagged that historical quote as a live advertisement. Every real advertising surface (content/docs/**, README.md, src/index.ts, templates/AGENTS.md) already uses the correct /skills subpath — the CHANGELOG is the only "offender", and it's a false positive.

Fix

Exclude **/CHANGELOG.md from the guard's grep surfaces. A changelog documenting the removal of an anti-pattern is not advertising it. One line + rationale comment.

Verification

pnpm --filter create-objectstack test18/18 pass (was 1 failing). Reproduced the single offender locally and confirmed the :(exclude)**/CHANGELOG.md pathspec drops it (1 → 0 matches).

Notes

🤖 Generated with Claude Code

…-boundary ratchet (main red)
The `no customer-facing surface advertises a repo-root skills install` guard
(template-consistency.test.ts) grepped `content/docs`/`skills`/
`packages/create-objectstack` for `skills add objectstack-ai/framework` not
followed by `/skills`, excluding only the test file — not CHANGELOG.md.
When Changesets versioned create-objectstack in RC mode, it baked #3101's
changeset prose into packages/create-objectstack/CHANGELOG.md. That entry
documents the fix by quoting the removed command in past tense
("…advertised `skills add objectstack-ai/framework --all` … now scoped to the
/skills subpath"), which tripped the ratchet and turned Test Core red on main
(pre-existing; first seen at e412fb6 / 631deba, before any of my changes).
A CHANGELOG documenting the REMOVAL of an anti-pattern is not advertising it —
only real customer-facing surfaces (docs, README, index.ts, AGENTS.md, which all
correctly use the /skills subpath) should count. Exclude `**/CHANGELOG.md` from
the guard's grep surfaces. Test-only change; no shipped behavior.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@os-zhuangos-zhuang added the skip-changeset PR has no user-facing published change; bypasses the changeset gate label Jul 20, 2026
@vercel

vercelBot commented Jul 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
specBuildingBuildingPreview, CommentJul 20, 2026 5:09am

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

This PR changes 1 package(s): create-objectstack.

8 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:

  • content/docs/ai/skills-reference.mdx(via create-objectstack)
  • content/docs/ai/skills.mdx(via create-objectstack)
  • content/docs/deployment/self-hosting.mdx(via create-objectstack)
  • content/docs/getting-started/index.mdx(via create-objectstack)
  • content/docs/getting-started/your-first-project.mdx(via create-objectstack)
  • content/docs/plugins/packages.mdx(via create-objectstack)
  • content/docs/releases/v15.mdx(via create-objectstack)
  • content/docs/releases/v9.mdx(via create-objectstack)

Advisory only. To re-verify, run the docs-accuracy-audit workflow scoped to these files:
node scripts/docs-audit/affected-docs.mjs origin/main → pass the list as args.docs.

@os-zhuang
os-zhuang merged commit 45a3769 into mainJul 20, 2026
19 of 21 checks passed
@os-zhuang
os-zhuang deleted the fix/skills-guard-exclude-changelog branch July 20, 2026 05:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xsskip-changesetPR has no user-facing published change; bypasses the changeset gatetests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@os-zhuang