Uh oh!
There was an error while loading. Please reload this page.
docs(approvals): document the full decision surface, send-back/resubmit, declared actions + viewer gating - #3349
Merged
Conversation
…it, declared actions + viewer gating The approvals guide only covered approve/reject. Bring it up to date with what has shipped: - Full decision-verb surface as a table (approve/reject/reassign/revise/ request-info/remind/recall/resubmit/comment) with route, who-may-call, and effect — including the /revise and /resubmit routes. - Send-back → resubmit revision lifecycle (ADR-0044), incl. the maxRevisions auto-reject and the required `revise` edge. - Decision file attachments (`attachments: string[]` on the audit row). - "Acting on requests in the console": the verbs ship as server-declared `sys_approval_request` actions rendered by the generic console action runtime (the inbox), so decisions need no per-action UI. - The server-computed per-viewer block (`viewer.can_act` / `viewer.is_submitter`) that gates the declared actions, and why a submitter never sees approver buttons while a position-addressed approver is never wrongly hidden. - Generalize the FORBIDDEN error-code wording to cover submitter-only verbs. Docs-only; no code or schema change. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016ypkQikZ55oWUHUnMebwXA
The latest updates on your projects. Learn more about Vercel for GitHub.
|
os-zhuang
marked this pull request as ready for review
July 20, 2026 06:02
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs catch-up for
content/docs/automation/approvals.mdx. The guide only documentedapprove/reject; this brings it in line with everything shipped across the recent approvals work (framework#3300/#3332/#3310, objectui#2697/#2710/#2719).What
approve/reject/reassign/revise/request-info/remind/recall/resubmit/comment— with route, who-may-call, and effect. This is the first time the/revise(send-back) and/resubmitroutes appear in the docs.revisefinalizes the roundreturnedand unlocks the record; the submitter reworks andresubmits (new round) orrecalls; pastmaxRevisionsa send-back auto-rejects; the node needs areviseedge.attachments: string[]ofsys_fileids on the audit row (e.g. a signed contract on the approve).sys_approval_request, rendered + executed by the generic console action runtime (the Approvals inbox), so a decision needs no per-action UI.viewerblock (viewer.can_act/viewer.is_submitter) that gates the declared actions — why a submitter never sees Approve/Reject and a position-addressed approver is never wrongly hidden.FORBIDDENerror-code wording to cover submitter-only verbs.Scope
Docs-only — no code or schema change. This also addresses the
docs-driftadvisory that flaggedapprovals.mdxon the recent approvals PRs.Verification
node scripts/check-doc-authoring.mjspasses; section structure unchanged in shape (new###subsections sit alongside Timeouts / Out-of-office under the lifecycle heading).Refs
framework#3300 (declared action set + routes) · framework#3332 (decision attachments) · framework#3310 (viewer gating) · objectui#2697 / #2710 / #2719 (console inbox) · ADR-0044 (send-back/resubmit)
🤖 Generated with Claude Code
Generated by Claude Code