Uh oh!
There was an error while loading. Please reload this page.
chore(create-objectstack): drop deprecated @types/tar devDependency - #3360
Merged
Conversation
tar v7 ships its own TypeScript declarations, so the standalone @types/tar stub is deprecated and redundant — it only emitted a `WARN deprecated @types/tar@7.0.87` line on every `pnpm install`. `import * as tar from 'tar'` now resolves against tar's bundled types; the package still builds and type-checks clean, and dist/ is byte-identical. devDependency-only, ships nothing (empty changeset — create-objectstack is in the lockstep fixed group and must not drag the stack up a patch for a no-op). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 8 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
… version The "Scaffold with repo dist" job built the runtime base image with a hardcoded `--build-arg OS_CLI_VERSION=latest`. During an RC window this skews protocols and fails the docker boot (pre-existing failure on `main`): ✗ package 'e2e-app' targets protocol ^16 (engines.protocol) but this runtime is protocol 15.0.0. The scaffolder pins `@objectstack/*` to `^<repo version>` (16.0.0-rc.1), so the generated project's `os build` emits an artifact targeting protocol 16. But the `latest` dist-tag still points at the last STABLE cli (15.1.1, protocol 15), so a base image built from `latest` runs `os start` at protocol 15 and rejects the protocol-16 artifact → container never becomes healthy. Derive OS_CLI_VERSION from the version the generated project actually resolved (`e2e-app/node_modules/@objectstack/cli`) instead of hardcoding `latest`. This keeps the runtime image in lockstep with the artifact's protocol in every case: the repo RC, the `latest` fallback the install step already handles, or a published stable. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Uh oh!
There was an error while loading. Please reload this page.
os-zhuang added a commit
that referenced
this pull request
Jul 21, 2026
…ty dir (#3376) The `Check Changeset` gate counted every `.md` in `.changeset/` (`find | wc -l`), so it only asserted the directory was non-empty — never that THIS PR contributed a changeset. In pre-release (RC) mode `changeset version` retains consumed changeset files, so the directory is permanently non-empty and the gate can never go red: #3373 merged a real spec / api-surface fix with no changeset while the step reported "Found 104 changeset(s)". Diff the base commit instead and count only changesets the PR adds. An empty-frontmatter changeset still counts — it is the sanctioned "releases nothing" declaration. Proven to go RED on #3373's diff (0 added) and GREEN on #3360's (1 added). Also backfills the missing #3373 changeset so the ViewFilterRule operator enum fix actually ships in the next release. Co-authored-by: Jack Zhuang <277994282+os-zhuang@users.noreply.github.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove the
@types/tardevDependency frompackages/create-objectstack.Why
tarv7 ships its own TypeScript declarations (itstypesfield points atdist/commonjs/index.d.ts), so the standalone@types/tarstub package is deprecated and redundant. Its only effect today is a warning on every install:The npm registry stub even says so: "tar provides its own type definitions, so you do not need this installed."
Verification
import * as tar from 'tar'insrc/index.tsresolves against tar's bundled types.pnpm -C packages/create-objectstack build(tsup) ✅tsc --noEmit: no new errors and no tar-related error — the 5 pre-existing errors are all insrc/templates/**(scaffold files referencing workspace packages, unchanged frommain).@types/tar; the package no longer appears anywhere inpnpm-lock.yaml.Release impact
None. devDependency-only — not shipped to consumers,
dist/byte-identical. Empty changeset (no version bump);create-objectstackis in the lockstepfixedgroup, so a patch would needlessly bump the whole stack for a no-op.🤖 Generated with Claude Code