Uh oh!
There was an error while loading. Please reload this page.
feat(showcase): enable the record History tab on Account - #3397
Merged
Conversation
The v16 sweep (#3358 §4 "Record History tab") couldn't exercise the tab because no showcase object opted into it: the console gates the History tab on object-level `enable.trackHistory` (RecordDetailView) — audit *capture* is always on, but the *tab* is opt-in — and the showcase only set `trackHistory` at the FIELD level (industry/status), which just selects which diffs are summarized. So the tab never rendered anywhere and #2691/#3293 (display-value diffs, computed-field exclusion) were undemonstrated. Set `enable: { trackHistory: true }` on Account (which already declares field-level `trackHistory` on `industry`/`status` for clean diffs). Verified in the running app: the Account detail now shows a **历史 / History** tab; after editing `industry`, it renders "Dev Admin · UPDATE · 行业: Retail → Technology" — field label + select **display values** (not raw stored codes/ids), no phantom value→null rows. `os validate` + `tsc --noEmit` pass. Follow-up to #3364 / #3393, from the #3358 sweep §4. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The #3358 v16 sweep (§4 "Record History tab") couldn't exercise the tab: no showcase object opted in. The console gates the History tab on object-level
enable.trackHistory(RecordDetailView) — audit capture is always on, but the tab is opt-in — and the showcase only settrackHistoryat the field level (industry/status), which merely selects which diffs get summarized. So the tab never rendered anywhere, and #2691/#3293 (display-value diffs, computed-field exclusion) were undemonstrated.What
enable: { trackHistory: true }on Account — which already declares field-leveltrackHistoryonindustry/status, so those changes summarize cleanly.Verified in the running app
industry, the tab renders "Dev Admin · UPDATE · 行业:Retail→ Technology" — the field label + the select display values (not raw codes/ids), a single real change, no phantom value→null rows.os validate✓ ·tsc --noEmit✓.Follow-up to #3364 / #3393; from the #3358 sweep §4.
@objectstack/example-showcaseis private → no changeset (skip-changeset).🤖 Generated with Claude Code