Skip to content

fix(plugin-approvals): ship _actions translations for the decision actions (objectui#2762 P0-3) - #3416

Merged
os-zhuang merged 1 commit into
mainfrom
claude/approval-center-optimization-77msf2
Jul 24, 2026
Merged

fix(plugin-approvals): ship _actions translations for the decision actions (objectui#2762 P0-3)#3416
os-zhuang merged 1 commit into
mainfrom
claude/approval-center-optimization-77msf2

Conversation

@os-zhuang

Copy link
Copy Markdown
Contributor

Summary

Framework half of objectstack-ai/objectui#2762P0-3 (动作标签 i18n): the Approval Center drawer showed English Approve / Reject / Reassign / Send back / Request info in a zh-CN workspace because @objectstack/plugin-approvals' translation bundle covered fields and views but had no _actions node — the console's _actions.<name>.label resolution had nothing to hit. (The UI half — DeclaredActionsBar actually resolving those keys — is objectstack-ai/objectui#2789.)

  • Re-ran the sanctioned extract (os i18n extract packages/plugins/plugin-approvals/scripts/i18n-extract.config.ts --locales=zh-CN,ja-JP,es-ES --fill=default --objects-only --out=…), which merged _actions scaffolding for all eight sys_approval_request decision actions into the four generated bundles, preserving every existing hand translation.
  • Translated the new leaves for zh-CN / ja-JP / es-ES: action label / confirmText / successMessage plus param labels/helpText for approval_approve, approval_reject, approval_reassign, approval_send_back, approval_request_info, approval_remind, approval_recall, approval_resubmit. zh-CN terms match the console's existing vocabulary (通过 / 拒绝 / 转签 / 退回修改 / 退回补充 / 催办 / 撤回 / 重新提交).
  • The merge also surfaced older gaps, now filled in all three locales: the returned status option, the sys_approval_action.action audit options (reassign/remind/request_info/comment/revise/resubmit/ooo_substitute), the attachments field label/help, and the my_pending / recent view empty states.

Verification

  • pnpm turbo build test --filter=@objectstack/plugin-approvals green (8/8 tasks)
  • Generated files only touched via the extractor + leaf-value translation (structure untouched)
  • Changeset: patch × 1

Refs objectstack-ai/objectui#2762, objectstack-ai/objectui#2789

🤖 Generated with Claude Code

https://claude.ai/code/session_01Cu48mLFUdRBmMh8Z8R3CVz


Generated by Claude Code

…tions (objectui#2762 P0-3)
The Approval Center drawer rendered the sys_approval_request declared
actions with their literal English labels in localized workspaces — the
plugin's bundle had no _actions node for the console's
_actions.<name>.label resolution to hit.
Re-ran 'os i18n extract' against the plugin config and translated the new
leaves for zh-CN / ja-JP / es-ES: all eight decision actions (label,
confirmText, successMessage, param labels/helpText) plus the gaps the
merge surfaced — the 'returned' status option, the sys_approval_action
audit-action options, the attachments field, and the my_pending / recent
view empty states.
Refs objectui#2762
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Cu48mLFUdRBmMh8Z8R3CVz
@vercel

vercelBot commented Jul 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
specReadyReadyPreview, CommentJul 22, 2026 9:25pm

Request Review

@os-zhuangClaude

Copy link
Copy Markdown
ContributorAuthor

CI status: same org-wide Actions outage as objectstack-ai/objectui#2789 — every job here (Auto Label, ESLint, Type Check, Check PR Size, …) fails ~2s after creation with no runner ever assigned (runner_id: 0). Not related to this diff; pnpm turbo build test --filter=@objectstack/plugin-approvals is green locally (8/8). I'll re-run the suites once runners recover.


Generated by Claude Code

@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

This PR changes 1 package(s): @objectstack/plugin-approvals.

4 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:

  • content/docs/automation/approvals.mdx(via @objectstack/plugin-approvals)
  • content/docs/plugins/packages.mdx(via @objectstack/plugin-approvals)
  • content/docs/releases/implementation-status.mdx(via @objectstack/plugin-approvals)
  • content/docs/releases/v9.mdx(via @objectstack/plugin-approvals)

Advisory only. To re-verify, run the docs-accuracy-audit workflow scoped to these files:
node scripts/docs-audit/affected-docs.mjs origin/main → pass the list as args.docs.

@os-zhuangClaude

Copy link
Copy Markdown
ContributorAuthor

✅ CI is green. Runners recovered at ~11:20 UTC Jul 24; all re-run suites passed: ESLint, TypeScript Type Check, Build Core, Test Core, Dogfood Regression Gate, CodeQL, Check Changeset, Check PR Size, and the docs-drift flag (advisory only — this PR is translation-bundle-only, so no doc behavior changed). Ready for review.


Generated by Claude Code

@os-zhuang
os-zhuang marked this pull request as ready for review July 24, 2026 12:11
@os-zhuang
os-zhuang merged commit 2dda6e7 into mainJul 24, 2026
21 of 35 checks passed
@os-zhuang
os-zhuang deleted the claude/approval-center-optimization-77msf2 branch July 24, 2026 12:12
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationsize/mtooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@os-zhuang@claude