Uh oh!
There was an error while loading. Please reload this page.
fix(plugin-approvals): give the decision actions a visual hierarchy (objectui#2762 P1-5) - #3437
Merged
Merged
Conversation
…ctui#2762 P1-5) approval_approve declares variant:'primary' and approval_reject declares variant:'danger' so a metadata-driven renderer highlights Approve and styles Reject as destructive — the drawer action bar gains the hierarchy the mobile card already had. Pure metadata; secondary levers stay tertiary. Refs objectui#2762 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Cu48mLFUdRBmMh8Z8R3CVz
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 4 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
os-zhuang
marked this pull request as ready for review
July 24, 2026 14:19
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Framework half of objectstack-ai/objectui#2762P1-5 (flat action hierarchy): the
sys_approval_requestdecision actions all rendered as equal-weight outlined buttons in the drawer's action bar, so the primary Approve didn't stand out and Reject didn't read as destructive.approval_approvenow declaresvariant: 'primary'approval_rejectnow declaresvariant: 'danger'Both values are from the existing
ActionSchema.variantenum (primary | secondary | danger | ghost | link). A metadata-driven renderer maps them onto its button styles — the objectui companion PR (objectstack-ai/objectui#2803) teachesDeclaredActionsBarto mapprimary→ filled default anddanger→ destructive — so Approve is highlighted and Reject reads as the irreversible action it is, matching the hierarchy the mobile card already has. Pure metadata; the secondary levers (reassign / send-back / request-info / remind / recall / resubmit) stay unstyled as tertiary.Verification
pnpm turbo build test --filter=@objectstack/plugin-approvalsgreen (8/8)Refs objectstack-ai/objectui#2762, objectstack-ai/objectui#2803
🤖 Generated with Claude Code
https://claude.ai/code/session_01Cu48mLFUdRBmMh8Z8R3CVz
Generated by Claude Code