Uh oh!
There was an error while loading. Please reload this page.
feat(spec)!: prune dead aria/performance from ReportSchema + dogfood the live report chart (report-liveness close-out) - #3496
Merged
Conversation
…the live report chart (report-liveness close-out) Follow-up to the #3463 report cleanup, closing out the 2026-06 ReportSchema liveness audit. That audit flagged `aria` and `performance` as dead — declared on ReportSchema (editable in the Studio report form) but read by no renderer. - spec: removed ReportSchema.aria (AriaPropsSchema) + ReportSchema.performance (PerformanceConfigSchema) and the now-orphan imports. Both schemas stay exported (still used by views/pages/charts); ReportChart keeps its own aria from ChartConfigSchema. No manifest/export change; report.mdx regenerated. Ships minor per the launch-window breaking-as-minor policy. - showcase: added `showcase_hours_by_status_chart` — a summary report with a `chart` block (est_hours by status, bar) + an Analytics nav item. This dogfoods the live DatasetReportChart path (chart.xAxis/yAxis over the bound dataset), which had no showcase coverage; browser-verified rendering. - docs/audits: the 2026-06 report-liveness audit is refreshed with a resolution banner (chart = WIRED not dead, aria/performance pruned, re-exports removed, joined preview fixed), and the audits README section 2 annotates the resolved report slice while leaving the open chart-view/dashboard debt untouched. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 104 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
…port seed.test.ts hardcoded 3 reports; the new showcase_hours_by_status_chart makes it 4 (summary, chart, matrix, joined). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Jul 27, 2026
Merged
os-zhuang added a commit
that referenced
this pull request
Jul 30, 2026
… silent drifts (#3786) (#4120) Every entry in METADATA_FORM_REGISTRY is a hand-written `defineForm` layout naming keys of a Zod schema it never imports. Four of the seventeen had already drifted, each silently — the schemas are deliberately not `.strict()`, so a key they do not declare parses clean and is stripped on the way to storage. - object: `capabilities` is not a key (it is `enable`) — 7 toggles saved nothing - object: the inline column grid offered 16 keys FieldSchema never declared - report: `aria`/`performance`, pruned by #3496, still rendered - hook/action: `body.memoryMb` was unauthorable - page: `interfaceConfig.sort` was unauthorable The gate is metadata-form-zod-reconciliation.test.ts, reconciling every registered form against getMetadataTypeSchema(). form-only is always a defect and not ledgerable; zod-only is ledgerable with a reason, checked for non-vacuity and for still resolving on both sides. Also: TRANSLATABLE_META_TYPES in rest is now derived from the translator dispatch (exported as TRANSLATABLE_METADATA_TYPES), and ActionAiCategorySchema's "update both sides" comment — whose source #3896 deleted — is retired.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Report-liveness close-out — follow-up to #3463. Closes out the 2026-06 ReportSchema liveness audit (
docs/audits/2026-06-reportschema-property-liveness.md), whose remaining findings were re-verified against current code.What changed
1. Prune dead
aria/performancefromReportSchema(spec, breaking→minor)The audit flagged both as dead — declared on
ReportSchema(editable in the Studio report form) but read by no renderer. Confirmed still dead in objectui (zero readers on the render path). Removed them + the now-orphanAriaPropsSchema/PerformanceConfigSchemaimports. Both schemas stay exported (still used by views/pages/charts);ReportChartkeeps its ownariafromChartConfigSchema. No manifest-key or public-export change;report.mdxregenerated.2. Refresh the stale audit doc + index
Every finding in the 2026-06 audit is now resolved, and one was wrong:
report.chartis live, not dead —DatasetReportRendererplotschart.xAxis/yAxisviaDatasetReportChart(DatasetReportRenderer.tsx:429-465,773-786). Added a resolution banner (chart=WIRED, aria/performance=pruned, re-exports=removed via #3463, joined-preview=fixed) and annotated the audits README section 2 (leaving the still-open chart-view/dashboard debt untouched).3. Dogfood the live report chart
report.charthad no showcase coverage — none of the three showcase reports declared achart. Addedshowcase_hours_by_status_chart(asummaryreport with achartblock:est_hoursbystatus, bar) + an Analytics nav item, so theDatasetReportChartpath is exercised by the showcase smoke.Verification
@objectstack/specbuild + 6850 tests pass;check:api-surface(unchanged — properties, not exports) ✓;check:docs(report.mdx in sync) ✓.examples/app-showcasetypecheck clean; backend boots with the new report (validchartshape parses).DatasetReportChart, with the summary table below;POST /api/v1/analytics/dataset/queryall 200.Refs #3463, #1878, #1890.
🤖 Generated with Claude Code