Uh oh!
There was an error while loading. Please reload this page.
feat(approvals): surface decisionOutputs keys on the request row (#3447 P2 UI enablement) - #3538
Merged
Merged
Conversation
… P2 UI enablement) The decision UI renders one input per author-declared output key; the set varies per request (each node declares its own), so it rides the request read (decision_outputs) rather than the object's static action params — the params array cannot enumerate a per-request field set. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📓 Docs Drift CheckThis PR changes 2 package(s): 104 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
…e next stage's expression approvers (#3447) The lead reviewer picks the co-signers in their decision (decisionOutputs); the co-sign node resolves them at entry from vars.lead_review.next_reviewers. Browser-dogfooded end to end: dialog renders the declared output field, the decide body nests outputs, and the co-sign slate resolves to the picked ids. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Surfaces the approval node's author-declared
decisionOutputskeys on the request read asApprovalRequestRow.decision_outputs— the data prerequisite for the decision dialog to render one input per key and POSToutputswith approve/reject (objectui follow-up in objectstack-ai/objectui).The set varies per request (each node declares its own), so it rides the row instead of
sys_approval_request's static actionparams— a static params array cannot enumerate a per-request field set.Small and additive:
rowFromRequestreadsdecisionOutputsoff the existing config snapshot; contracts type + test. Follow-up to #3447 P2 (#3532).🤖 Generated with Claude Code