Uh oh!
There was an error while loading. Please reload this page.
Fix missing @objectstack/core dependency in examples/basic - #453
Merged
hotlong merged 5 commits intoFeb 1, 2026
Conversation
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 20.19.30 to 25.0.10. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-version: 25.0.10 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dependabotBotforce-pushed
the
dependabot/npm_and_yarn/types/node-25.0.10
branch
from
February 1, 2026 02:49
dd57d39 to
73467e1Compare…in examples/basic Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request upgrades the @types/node dependency from version 20.x to 25.1.0 across the entire monorepo and fixes a missing dependency issue in the examples/basic package.
Changes:
- Upgraded
@types/nodefrom^20.x.xto^25.1.0across all packages and examples - Added missing
@objectstack/coredependency toexamples/basic/package.json - Added type assertion in
logger-example.tsto resolve type inference issues
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated root package @types/node to ^25.1.0 |
| packages/spec/package.json | Updated @types/node to ^25.1.0 |
| packages/core/package.json | Updated @types/node to ^25.1.0 |
| packages/cli/package.json | Updated @types/node to ^25.1.0 |
| packages/ai-bridge/package.json | Updated @types/node to ^25.1.0 |
| packages/plugins/plugin-hono-server/package.json | Updated @types/node to ^25.1.0 |
| packages/plugins/plugin-msw/package.json | Updated @types/node to ^25.1.0 |
| apps/docs/package.json | Updated @types/node to ^25.1.0 |
| examples/ai-support/package.json | Updated @types/node to ^25.1.0 |
| examples/basic/package.json | Added @objectstack/core dependency and updated @types/node |
| examples/basic/logger-example.ts | Added type assertion for db service to fix TypeScript compilation |
| pnpm-lock.yaml | Updated lockfile with all dependency version changes and resolution updates |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
| init: async (ctx: PluginContext) => { | ||
| const db = ctx.getService('db'); | ||
| const db = ctx.getService('db') as { connected: boolean }; |
There was a problem hiding this comment.
The type assertion used here bypasses TypeScript's type safety. The getService method is already generic and should be able to infer or accept a type parameter. Consider using the generic parameter instead of type assertion for better type safety.
For example, you could use: const db = ctx.getService<{ connected: boolean }>('db');
This would provide the same type information while maintaining the intent of the generic method and avoiding the use of as which can hide potential runtime errors.
Suggested change
| constdb=ctx.getService('db')as{connected: boolean}; | |
| constdb=ctx.getService<{connected: boolean}>('db'); |
CopilotAI
changed the title
[WIP] Update documentation for actions runFix missing @objectstack/core dependency in examples/basicFeb 1, 2026
dependabotBotforce-pushed
the
dependabot/npm_and_yarn/types/node-25.0.10
branch
from
February 1, 2026 03:05
73467e1 to
5813a7aComparedependabotBotforce-pushed
the
dependabot/npm_and_yarn/types/node-25.0.10
branch
from
February 1, 2026 03:23
5813a7a to
987302aComparehotlong
merged commit Feb 1, 2026
db5cb32
into
dependabot/npm_and_yarn/types/node-25.0.10
5 of 6 checks passed
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI build failure in examples/basic after @types/node upgrade. The logger-example.ts imports from @objectstack/core but the dependency wasn't declared, causing TS2307 module resolution errors.
Changes
@objectstack/core: workspace:*dependencyOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.