Uh oh!
There was an error while loading. Please reload this page.
feat(spec)!: contracts 手写 interface 与域内 zod 推导类型收敛(3 簇 11 名,#4535·A3) - #4568
Merged
Merged
Conversation
…es (#4538) Each of the 11 baseline rows judged individually against a three-repo import-level scan (framework, cloud, objectui): - Converged onto the domain zod declaration, re-exported from ./contracts: NotificationChannel (system), ValidationResult / HealthStatus / StartupOptions / PluginStartupResult (kernel), JobExecution (system, after renaming the schema's dead `duration` to the runtime-true `durationMs`), AnalyticsQuery (data, after the schema dropped the `timezone` .default('UTC') the /analytics entry always refused to apply - absence means the engine resolves org timezone, #1982/#2018). IStartupOrchestrator.orchestrateStartup now takes StartupOptionsInput. - Renamed: contracts DriverCapabilities -> AnalyticsDriverCapabilities (two live concepts shared one name; the data domain's driver feature-flag record keeps it). @objectstack/service-analytics re-export renamed in lockstep. - Removed dead domain-side declarations (zero consumers in all three repos; last of the #4411 family): system MetadataExportOptions(Schema) / MetadataImportOptions(Schema) - the contracts IMetadataService parameter interfaces own the names now - and the system `JobSchedule = Schedule` back-compat alias (authoring tier keeps its real name, Schedule). @objectstack/metadata now re-exports the two Metadata*Options names from ./contracts, the shape its own manager implements. All 11 dual-source-exports.baseline.json rows deleted; baselines (api-surface, authorable-surface, json-schema.manifest, reference docs) regenerated via check:generated --fix; the authorable-surface lines for the removed runtime option bags deleted by hand per the #4458 precedent (not authorable metadata - no tombstone, no D2 conversion). Out-of-scope finding filed unassigned as #4567 (defineJob cron envelope vs croner). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M9uWvoEp9CoLzYjNExj9sL
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
📓 Docs Drift CheckThis PR changes 4 package(s): 116 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
os-zhuang
marked this pull request as ready for review
August 2, 2026 06:19
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Aug 2, 2026
Merged
akarma-synetal pushed a commit
to akarma-synetal/framework
that referenced
this pull request
Aug 3, 2026
…./api 侧死删 + 改名 OpenApiWebhookEvent (objectstack-ai#4572) (objectstack-ai#4581) * feat(spec)!: resolve the WebhookConfig/WebhookEvent dual source — ./api pair removed/renamed, ./integration keeps the bare names (objectstack-ai#4572) The four objectstack-ai#4535-C1 baseline rows were the objectstack-ai#4411 trap in cross-form: ./api's WebhookEventSchema was a z.object (OpenAPI 3.1 webhook definition) while ./integration's is a z.enum of connector event types — same names, two concepts, and which one you got depended only on the import path. Import-statement-level scan across framework, cloud and objectui: zero external consumers on either side (each pair's only importer is its own unit test; cloud and objectui reference neither name). - api WebhookConfig(Schema): DEAD — wired into nothing, not even RestServerConfigSchema; no runtime reads a REST webhook config. Deleted (major window). Its authorable-surface lines deleted by hand per the objectstack-ai#4458/objectstack-ai#4568 precedent (plugin-config type, not authorable metadata — no tombstone, no D2 conversion). - api WebhookEvent(Schema): renamed OpenApiWebhookEvent(Schema) — it is the OpenAPI 3.1 top-level `webhooks` descriptor and now sits in the existing OpenApi* family; OpenApi31ExtensionsSchema wiring updated, authored shape unchanged. - integration WebhookConfig/WebhookEvent: untouched, now sole owners of the bare names, so the pair stays one coherent family in one domain. dual-source-exports.baseline.json: exactly the 4 named rows removed (35 → 31). json-schema.manifest: api/WebhookConfig retired, api/WebhookEvent → api/OpenApiWebhookEvent (deliberate rename, not a silent drop). Changeset: @objectstack/spec major with FROM → TO lines. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M9uWvoEp9CoLzYjNExj9sL * chore(spec): regenerate api-surface + reference docs for objectstack-ai#4572 (check:generated --fix, 2 proved stale) api-surface.json: -WebhookConfig(Schema)/-WebhookEvent(Schema) on ./api, +OpenApiWebhookEvent(Schema). Reference docs: the api/connector.mdx page (which documented only the removed ./api pair, under a misleading name) is no longer emitted; rest-server.mdx now documents OpenApiWebhookEvent. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M9uWvoEp9CoLzYjNExj9sL * test(spec): make the objectstack-ai#4572 bare-name pin compile-time — the runtime barrel import timed out under parallel turbo load typeof import('./rest-server.zod') is type-level only; if a bare WebhookEventSchema/WebhookConfigSchema export returns, the conditional type flips to `true` and `tsc --noEmit` fails the false assignment. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M9uWvoEp9CoLzYjNExj9sL --------- Co-authored-by: Claude <noreply@anthropic.com>
akarma-synetal pushed a commit
to akarma-synetal/framework
that referenced
this pull request
Aug 3, 2026
… ./api,./kernel 侧死删 (objectstack-ai#4587) (objectstack-ai#4603) * feat(spec)!: resolve the MetadataEvent/MetadataBulkRegisterRequest dual source — ./kernel copies removed, ./api keeps the bare names (objectstack-ai#4587) The three objectstack-ai#4535-C2 baseline rows were the objectstack-ai#4411 trap on the kernel metadata family: MetadataEvent(Schema) and MetadataBulkRegisterRequestSchema each had a second, different declaration in ./kernel, and which shape a consumer got depended only on the import path. Import-statement-level scan across framework, cloud and objectui: - ./kernel copies: zero importers outside their own unit test in all three repos. The kernel MetadataEvent lifecycle vocabulary (metadata.registered/.../exported) has NO producer anywhere; the kernel bulk-register per-item `namespace` field matches no enforced write path (IMetadataService.bulkRegister and MetadataManager.bulkRegister both take {type,name,data} items only). - ./api MetadataEvent is the live realtime contract: MetadataManager publishes metadata.{type}.{created|deleted} events and @objectstack/client / client-react subscribe against the type. - ./api MetadataBulkRegisterRequestSchema is the POST /api/meta/bulk/register contract whose item shape matches the runtime. Disposal (route 1, dead-side delete, v17 major window): both kernel copies removed; ./api is the sole owner of the bare names. Name continuity for the kernel-only type alias: `MetadataBulkRegisterRequest` (z.input) is now exported from ./api beside its schema, per the family convention and the objectstack-ai#4570 docs-import concern. Compile-time pin (typeof import conditional type, objectstack-ai#4581 pattern) keeps the bare names out of ./kernel; new events.test.ts covers the surviving ./api declarations. dual-source-exports.baseline.json: exactly the 3 named rows removed (31 -> 28). json-schema.manifest: kernel/MetadataEvent and kernel/MetadataBulkRegisterRequest retired deliberately; their 11 authorable-surface rows hand-deleted per the objectstack-ai#4458/objectstack-ai#4568/objectstack-ai#4581 precedent (plugin TS types, schema bodies deleted — no silent-strip path, misuse fails at the import site at compile time). Changeset: @objectstack/spec major with FROM -> TO migration lines. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M9uWvoEp9CoLzYjNExj9sL * chore(spec): regenerate api-surface + reference docs for objectstack-ai#4587 (check:generated --fix, 2 proved stale) api-surface.json: ./kernel loses MetadataEvent(type)/MetadataEventSchema and MetadataBulkRegisterRequest(type)/MetadataBulkRegisterRequestSchema; ./api gains the MetadataBulkRegisterRequest type alias beside its schema. Reference docs: the api/metadata-plugin.mdx page (which documented the removed kernel pair under the api section and advertised a then-nonexistent ./api type import) is no longer emitted; api/events.mdx now documents MetadataEvent, api/metadata.mdx documents MetadataBulkRegisterRequest, and kernel/metadata-plugin.mdx drops the removed schemas. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M9uWvoEp9CoLzYjNExj9sL * chore(spec): regenerate reference docs after merging main's import-surface gate (objectstack-ai#4595) The merge brought in build-docs' new import-surface ratchet. This PR's MetadataBulkRegisterRequest type alias on ./api closes the gap the fresh baseline had accepted, so its line is deleted (shrink-only ratchet). --------- Co-authored-by: Claude <noreply@anthropic.com>
akarma-synetal pushed a commit
to akarma-synetal/framework
that referenced
this pull request
Aug 3, 2026
…ai#4610) (objectstack-ai#4638) * feat(spec)!: resolve the notification-vocabulary dual sources — ./ui Notification(Config) removed, ./system NotificationConfig removed, ./api keeps the bare names (objectstack-ai#4610) The four objectstack-ai#4535-C3 baseline rows were the objectstack-ai#4411 trap on the notification vocabulary: Notification(Schema) had a second declaration in ./ui diverging from ./api, and NotificationConfig(Schema) had two declarations (./system vs ./ui) that shared nothing but the name. Import-statement-level scan across framework, cloud and objectui: - ./api Notification(Schema) is the live REST inbox-row contract: embedded in ListNotificationsResponseSchema, part of NotificationProtocol, implemented by @objectstack/client, served by the runtime notifications domain, and mirrored by contracts' InboxNotification (ADR-0030: the bell reads this shape). - ./ui Notification(Schema) — a toast/banner instance shape — had zero importers outside its own unit test; objectui pins only the presentation enums (NotificationType/Position/ActionSchema), which stay. - ./system NotificationConfig(Schema) — a channel+template+recipients+ schedule+retryPolicy+tracking wrapper — had zero importers, is wired into no parent schema, predates ADR-0030's accepted delivery model (NotificationService.emit / NotifyConfigSchema / sys_* objects), and advertised unenforced capability (objectstack-ai#3197 dead-letter channels). - ./ui NotificationConfig(Schema) — a toaster global config — had zero importers. Disposal (route 1, dead-side delete, v17 major window): the ./ui pair and BOTH NotificationConfig declarations removed; ./api is the sole owner of the bare Notification(Schema) names and NotificationConfig left the export surface entirely. Compile-time pins (typeof import conditional type, objectstack-ai#4581 pattern) keep the bare names out of ./ui and ./system; the surviving ./api declaration is already covered by api/protocol.test.ts. dual-source-exports.baseline.json: exactly the 4 named rows removed (28 -> 24). json-schema.manifest: system/NotificationConfig, ui/Notification and ui/NotificationConfig retired deliberately; their 25 authorable-surface rows hand-deleted per the objectstack-ai#4458/objectstack-ai#4568/objectstack-ai#4581/objectstack-ai#4603 precedent. api-surface + reference docs regenerated via check:generated --fix (2 proved stale; the api/notification.mdx page folds into api/protocol.mdx where the declaration lives). docs-import-surface baseline (objectstack-ai#4595): untouched. Changeset: @objectstack/spec major with FROM -> TO migration lines. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M9uWvoEp9CoLzYjNExj9sL * docs(audits): 严格性台账跟随 objectstack-ai#4610 —— ui/notification.zod.ts 站点 3 → 1 删除 ./ui 的 Notification / NotificationConfig 两个形状后,台账里 `notification.zod.ts` 那行声明的站点数过期(gate 点名 ledger:454: declares 3 site(s), found 1)。把它从「3 ea」的合并行拆出单列为 1, 并写明为何掉了两个站点;`ui/` 章节总计 200 → 198 相应收敛。 check:strictness-ledger 恢复绿(67 文件 / 5 目录,站点数与章节总计均衡); 同 job 的其余源码审计(liveness / empty-state / variant-docs / exported-any / react-declaration-parity / skill-examples)一并复跑通过。 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M9uWvoEp9CoLzYjNExj9sL --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#4538
单 PR 覆盖 issue 列出的全部名字(按协调人指示;issue 标题写 9 条,正文实际列了 11 个名字/基线行,以正文为准)。逐名做了三仓 import 级扫描(本仓 + cloud + objectui shallow clone)判定真源,基线 11 行全部删除,
check:dual-source-exports归零通过且无新增。逐名判定与处置
NotificationChannelNotificationConfigSchema.channel消费 schema 侧ValidationResultHealthStatusany→unknown收紧;两侧 spec 外零消费StartupOptionsorchestrateStartup参数改StartupOptionsInputPluginStartupResultplugin: Plugin+error?: Error无法被 zod 描述,收敛到可校验形状JobExecutiondurationMs);声明:归 systemduration→durationMs后 contracts 改为 re-exportdurationMs,DB 列duration_ms;system 版duration零消费,描述的是从未存在过的记录JobSchedule= Schedule遗留别名ScheduleAnalyticsQuerytimezone的.default('UTC')后 contracts 改为 re-export/analytics入口一直拒绝应用该 default(#1982/#2018:缺席=引擎解析 org 时区),default 声明的是运行时拒绝执行的边界;去掉后 schema 全程无 transform,两 tier 合一,contracts/data/cloud 三方消费全部继续编译DriverCapabilitiesAnalyticsDriverCapabilities;service-analytics 同步改名IDataDriver.supports,contracts/data-driver.ts 自己就 import data 侧),contracts 侧是 analytics 策略链三元组 —— 占名者是后者,证据无歧义MetadataExportOptionsMetadataManager.exportMetadata实现的是 contracts 形状(options.types驱动导出);system 版(output目录袋)三仓零消费,是 #4411 家族最后幸存者 —— issue 猜的"改名"经扫描证实为"死侧删除",contracts 保名MetadataImportOptionsconflictResolution/validate/dryRun;system 版(source/strategy)零消费顺手修正:
@objectstack/metadata的公开 re-export 此前把这两个名字指向 system 死侧(与它自己 manager 实现的形状相反),已改指./contracts。基线与生成物
dual-source-exports.baseline.json:删除且仅删除上述 11 行(48→38 行,门禁点名的 stale 行与删除行完全一致,无额外 stale)。authorable-surface.json:手删 9 行(两个死 options 袋的 8 键 +JobExecution:duration),durationMs由 gen 记录 —— 按 refactor(spec)!: remove the kernel metadata-loader envelope family — 11 names declared twice with different shapes (#4411) #4458 先例:运行时 option 袋非可授权 metadata,无 tombstone、无 D2 conversion,changeset 携带 FROM→TO。json-schema.manifest.json−2;api-surface.json、reference docs 经check:generated --fix再生。@objectstack/specmajor、@objectstack/service-analyticsmajor、@objectstack/metadatapatch,含全部 FROM→TO 与一行修法。验证
pnpm --filter @objectstack/spec build✅;check:generated8/8 ✅;check:dual-source-exports✅(4303 名字/16 入口,无新增,38 条基线)test286 文件 / 7268 用例全过;typecheck✅pnpm build71/71 ✅;pnpm typecheck122/122 ✅;pnpm test132/132 ✅(131 within one turbo run;@objectstack/dogfood#test因外层超时被误杀后单独重跑:76 文件 / 443 用例通过)范围外发现
#4567(未指派):
defineJob解析后的 cronexpression是表达式信封,AppPlugin → CronJobAdapter → croner全程无人降解,croner 抛 "Pattern has to be of type string" 被 warn 吞掉 —— 声明式 cron job 静默调度失败(showcase 的HealthSweepJob即中招)。与本 PR 的类型收敛正交,未在此修。🤖 Generated with Claude Code
https://claude.ai/code/session_01M9uWvoEp9CoLzYjNExj9sL
Generated by Claude Code