Uh oh!
There was an error while loading. Please reload this page.
docs(spec): hook positions JSDoc/describe 换掉不可达的 services.sharing 正例 (#6001) - #6314
Merged
Merged
Conversation
`positions` 的边界结论不变 —— 描述性、非授权输入。变的是它旁边那个例子,
因为例子本身是缺陷形状:
FROM「forwarding it as the sharing service's evaluation context
(`services.sharing.canEdit(..., { positions })`,两页 runtime-services
文档都这么教)」
TO 一个 hook 真拿得到的通道 —— 定制消息、经 `ctx.api` 跑业务判断、日志 ——
并写明 hook 上下文没有 `services` 键。
#5720 已实测钉死:hook 上下文逐键构造,ObjectQL 的 buildSession() 与
buildSandboxContext()(runtime/src/sandbox/body-runner.ts —— input /
previous / user / session / event / object / result / api / log / crypto)
都不设 `services`。于是 `services.sharing.canEdit(…)` 在 hook 里是
`undefined()`,外面惯常包的 `if (!ok) throw` 会拒掉每一次写。文档举为正例的
那个形状,恰是对全量流量 fail-close 的那个。
被引用的两页文档在 PR #5938 后已反转(sharing-service.mdx 新增
「Enforcement is automatic — do not re-check it in a hook」;examples.mdx
改教 `ctx.api`),这段 JSDoc 是最后一处还在教已撤回形状的地方。交叉引用改指
那一节。
JSDoc 与 `.describe()` 同改:describe 是 /api/v1/meta/types/hook 对外供给、
Studio 表单渲染的那一份,只改 JSDoc 会把缺陷例子留在作者真正会看的面上。
仅文案,无 schema / 校验 / 运行时行为变化。
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011M7UwH25Unfi73UHim7ajYThe latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 112 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
qq9340100
marked this pull request as ready for review
August 7, 2026 15:08
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#6001
hook.zod.ts的session.positions文档把services.sharing.canEdit(..., { positions })举为 hook 读取正例 —— dev 亲测复核(不采信转述):engine.ts 的 hook 上下文与buildSandboxContext()(body-runner.ts:307-324)两条路径都无services键,该正例运行时是undefined()、配合惯用if (!ok) throw全拒。语义结论(描述性、非授权输入)原样保留;仅举例通道换成 hook 真实持有的ctx.api侧,并把已被 PR #5938 反转的 docs 交叉引用改指 sharing-service.mdx 的 "do not re-check it in a hook" 节。范围裁量(dev 报请复核):同一缺陷正例同时存在于 JSDoc 与 12 行下的
.describe()—— 两处都修。理由:/api/v1/meta/types/hook与 Studio 表单实际外露的是.describe(),只修 JSDoc 等于把缺陷留在卡片点名的那个传播面上。同句同缺陷,无越界。Generated by Claude Code