Uh oh!
There was an error while loading. Please reload this page.
docs(spec): 字段级/section 级 visibleWhen 收窄 current_user 过度宣称 (#6146) - #6315
Merged
Merged
Conversation
`FormField.visibleWhen` 与 `FormSection.visibleWhen` 把 runtime 绑定根写作 「`record` + `current_user`」。后半截在该层从来不成立,且失败是静默的: FROM「Root: `record`+`current_user` (runtime forms) or `data` (metadata forms)」 TO「Root: `record` (+ `previous`, `parent`) in runtime forms, or `data` in metadata forms」,并写明 `current_user` 在此层未绑定。 字段级/section 级规则由 @object-ui/core 的 evalFieldPredicate / resolveFieldRuleState 求值,只绑 `record`、`previous` 与 `extra` scope (master-detail 行项的 `parent`),再无其他。全部生产调用点都不传用户 scope; objectui#1582 对作者端自动补全钉的是同一套 (FIELD_RULE_ROOTS = ['record','previous','parent'],注释明写 「nothing else (no `current_user`)」)。 为什么这不只是措辞问题:未绑定标识符会让求值 fault,而 fault 一律落到调用方 fallback —— 可见性的 fallback 是 `true`。于是完全照文档写出的谓词 (`'admin' in current_user.positions`)不但没隐藏字段,反而让字段**恒可见**。 照文档办事的作者拿到的是自己所写的反面,且发生在最难察觉的那一面。 `current_user` 在**选项级** visibleWhen(SelectOption)仍有文档、且仍然正确: 选项走另一套求值器 resolveCascadingOptions,对宿主 predicate scope 求值,确实 绑定它(ADR-0068 / objectui#2284)。该处 JSDoc 原先声称选项环境「与字段级 visibleWhen 是 SAME binding environment」—— 恰是那条为假的等式 —— 现改为写明 两者不对称。 仅文档,无 schema / 校验 / 运行时行为变化。 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011M7UwH25Unfi73UHim7ajY
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 112 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
This was referenced Aug 7, 2026
qq9340100
marked this pull request as ready for review
August 7, 2026 15:08
Uh oh!
There was an error while loading. Please reload this page.
qq9340100 pushed a commit
that referenced
this pull request
Aug 7, 2026
解 view.zod.ts 的 FormField.visibleWhen JSDoc/describe 相撞,按 keep-both: - 保留 #6146(PR #6315)的根表述:runtime 根为 `record`(+ `previous` / `parent`),字段级不绑 `current_user` —— 含 fault → fallback=true 的危险 方向说明(该谓词不是隐藏字段,而是让字段恒可见),以及 current_user 只在 per-option 面解析的指路。 - 保留本分支(#6254)的 repeater 段落:repeater 子字段把 `data` 重绑为**行**, 但根在任何深度仍拼作 `data`,故裸标识符未绑定、同样 fault open。 两段语义独立、方向互补 —— 一段讲「根里没有什么」,一段讲「根在深处指向什么」, 都落在同一个 fail-open 后果上,故在 JSDoc 与 describe 中并存,措辞相互衔接。 FormSection.visibleWhen 无冲突,取 #6146 版本。 content/docs/references/ui/view.mdx 未手改:按合并驱动的提示先跑 `gen:schema` 再跑 `gen:docs`,由合并后的源重生成。 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011M7UwH25Unfi73UHim7ajY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#6146
执行维护者裁定方向 1(文档收窄)。dev 在只读 objectui 克隆里亲证前提:
evalFieldPredicate(fieldRules.ts:115-157)的绑定恰为{ record, previous, extra(parent) },无任何 user 绑定;objectui#1582 的 pin 逐字在案。修正面:view.zod.tsFormField(:1410)与 FormSection(:1504)的 JSDoc + describe:record+current_user→record(+previous/parent),并写明危险方向 —— 未绑定标识符 fault 后 fallback=true(:189),想隐藏字段的谓词让字段永久可见;field.zod.ts(~:122-136)per-option 文档的交叉引用修正(PM 范围修正令):删除「与字段级同一绑定环境」的假等式,current_user在 per-option 面保留(真实绑定,objectui form.tsx:769-773 佐证);content/docs/ui/views.mdx:373手写表格行同款断言,同因同修;references 两页经gen:docs重生成(非手改,diff 恰为 3 行)。卡片实测更正:生产调用点是五个而非三个(form.tsx ×3、WizardForm、GridField),全部不传 user scope —— 加强而非削弱结论。页面级 visibleWhen 文档(
page.<var>/current_user)是另一求值器,证据未触及,刻意未动。Generated by Claude Code