Uh oh!
There was an error while loading. Please reload this page.
feat(spec): bind webhook/connector/sharing_rule schemas at the /meta write door (#6245) - #6351
Merged
Merged
Conversation
三类 stack collection 此前可经 `PUT /api/v1/meta/<type>/:name` **零校验**写入:
spec-invalid 的 webhook body 原样存库并回 `success: true` —— 仓库自己钉着这个
行为(protocol-meta.test.ts 保存 `{name,url,events:['x.created']}` 并断言成功,
而 `events` 是 `triggers` 的别名、`'x.created'` 不是 WebhookTriggerType,
那条 webhook 什么都没订阅)。
这正是 #5271 为 `api` 关掉的洞,换三扇门再来一次:三类今天已被产出与消费
(artifact ingest 把 `defineStack({webhooks, connectors, sharingRules})` 映射为
正是这三个 type 名的 item),却都不是 `MetadataTypeSchema` 成员,于是
`getMetadataTypeSchema()` 返回 undefined、`resolveOverlaySchema()` 返回 null,
`saveMetaItem` 走了它文档化的「未注册类型 → 不校验直接存」分支。enforced but
undeclared。
FROM:`PUT /meta/webhook/my_hook` 任意 JSON → 200 `{success:true}`,不校验入库。
TO :坏 body → `422 INVALID_METADATA`,带结构化 issues[],与其余 kind 同一信封;
合规 body 一如既往被接受。
每类绑定的都是**其 stack collection 已在用的同一 schema**,使同一 body 不会
「在 stack 里合法、经 /meta 非法」或反之:WebhookSchema、
DeclarativeConnectorEntrySchema、SharingRuleSchema。connector 刻意绑
declarative entry 而非裸 ConnectorSchema —— entry schema 携带 ADR-0097 §3/§5
规则(provider-bound 实例不得经 `authentication` 内联凭据,不得自撰
actions/triggers);绑基类会让 stack 拒收的内联密钥形状经 /meta 依然可达,
那就是本 bug 类别换把钥匙再来一遍。
**无新能力面**:仅绑 shape —— 无 MetadataTypeSchema 成员、无
DEFAULT_METADATA_TYPE_REGISTRY 条目,故所有授权判定仍走同一条
「无静态条目 ⇒ 合成 allowRuntimeCreate: true」分支。写**门**不变,新增的只有
422。#2657 的 B/C 裁决不动、不预设。
定级 minor(按 #5271 先例):此前回 200 的写入现在可能回 422。
随行一处 schema 改动,且是承重的:CriteriaSharingRule / SharingRule 现声明
ADR-0010 保护信封。两条元数据装载路径都对**每个**类型调用 applyProtection,
故 package 装载的 sharing rule 本就带着这些键 —— 而该 shape 是 .strict(),
它不是丢弃而是**拒绝**它们。这一点此前不可见,只因该类型在 overlay 门上
解析不到 schema。绑了门却不加这个 spread,新增的 422 就会打在运行时自己的
戳上、而不是打在作者的坏输入上。metadata-type-schemas.test.ts 里既有的守卫
恰好点名了这个失败并开出这剂药方。纯新增、纯内部键,作者字段不变。
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011M7UwH25Unfi73UHim7ajYThe latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 112 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
qq9340100
marked this pull request as ready for review
August 7, 2026 16:19
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#6245
按 #5271 形状关掉
PUT /meta三类零校验写洞:webhook / connector / sharing_rule 绑 Zod schema(静态UNREGISTERED_KIND_SCHEMAS表,getMetadataTypeSchema末位、插件覆盖胜出),不注册 kind、无新能力面、权限判定逐字节不变;错 body 422 INVALID_METADATA,#2657 的 B/C 裁决不被预设。connector 绑DeclarativeConnectorEntrySchema(stack.zod.ts:477既有权威;绑 base 会重开 ADR-0097 §3 内联凭据洞)。BaseSharingRuleSchema补...MetadataProtectionFields(必需:否则新 422 打在运行时保护戳上,违反「不拒 stamped 行」红线;守卫测试字面处方)。pin 翻转 + 6 新测;changeset minor(#5271 同款定级)。三处 dev 裁量详录于 #6245 的终报转录评论,PM 已逐条复核接受。与 #6083 零碰撞(未触别名区)。
Generated by Claude Code