Uh oh!
There was an error while loading. Please reload this page.
fix(spec): aria 墓碑不再指向同一大版本里已退休的落点 (#6756) - #6854
Merged
os-project-manager merged 1 commit intoAug 9, 2026
Merged
Conversation
`dashboard.widgets[].aria` 的 retiredKey() 提示声称共享的 `AriaProps` "stays live on `app.aria`",而 `App.aria` 自己就是同一个 17.0.0 里被移除的 retiredKey() 墓碑;两行之后推荐的 `os migrate meta --from 16` 恰恰会把 `aria` 从 app 源里剥掉。反向的一半同样坏:`App.aria` 让作者写到 "component/widget",widget 那一半正是 #5010 退休的 `dashboard.widgets[].aria`。 两个墓碑互指对方已退休的键。 按 liveness ledger 实测重新校准落点:page.aria / page.components[].aria / list view 的 aria 为 live;action.aria 为 live 但 PARTIAL;chart.aria 无 ledger 行,故不列入 —— 多列一个没有渲染器读的面就是在重犯本 issue 修的错。 migrate 动词由 "rewrite it" 改为 "remove it":该转换调用 stripKeys,做的是剥离。 接受集合逐字节不变:改动全部是 retiredKey() 的 guidance 参数、注释与 ledger 的 note 散文。gen:schema 独立复核 1308 个 authorable default 未变。 两处既有断言此前把缺陷钉死(dashboard.test.ts 要求 /app\.aria/、 app.test.ts 期待 'component/widget'),已按其原意重新瞄准而非删除。 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018ffcE95NaMJcL9XJ9VDYgk
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 112 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
This was referenced Aug 9, 2026
os-project-manager
marked this pull request as ready for review
August 9, 2026 01:05
Uh oh!
There was an error while loading. Please reload this page.
os-project-manager
deleted the
claude/issue-6756-aria-tombstone-dead-pointer
branch
August 9, 2026 01:21
This was referenced Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#6756
缺陷
dashboard.widgets[].aria的retiredKey()提示 —— 也就是升级中的作者实际收到的那个字符串 —— 声称共享的AriaProps形状「stays live onapp.aria」。但App.aria自己就是一个retiredKey()墓碑，和它在同一个 17.0.0 里被 2026-06 app liveness 审计移除。提示把作者送向一扇不存在的门，然后在两行之后递给他们os migrate meta --from 16—— 而app-dead-authoring-keys-removed这个转换恰好会把aria从 app 源里剥掉。按提示操作的代价是两轮返工外加一次静默的数据丢失。反向的一半同样是坏的：
App.aria的处方说「declareariaon the component/widget」，widget 那一半指的正是 #5010 退休掉的dashboard.widgets[].aria。两个墓碑互相指向对方已退休的键。实测的锚点（issue 记录的
252f71bd6已过期，全部在 freshmainc32944d6上文本检索复测）packages/spec/src/ui/dashboard.zod.tsimport 注释14-17（claim 在15）packages/spec/src/ui/dashboard.zod.ts墓碑上方内联注释602-611（claim 在610-611）packages/spec/src/ui/dashboard.zod.tsretiredKey()guidance612-622（claim 在619-620，migrate 句在621）packages/spec/src/migrations/registry.tsprotocol-17 迁移记录895-896packages/spec/liveness/dashboard.jsonledgernote150packages/spec/src/ui/app.zod.ts互指的一半（issue 列为 "Related, likely the same fix"）1400-1408另外两处 issue 未列、但携带同一 reciprocal 错误、由 sweep 找出并一并修正：
packages/spec/liveness/app.json:253、packages/spec/src/ui/app.form.ts:89-91（均为散文/注释）。AriaProps的真实去向（按实测，不按假设）git grep "aria: AriaPropsSchema" -- packages/spec/src得 25 处活声明（component 20 / page 2 / action 1 / chart 1 / view 1）。以仓库自己的 liveness ledger 为判据：page.aria、page.components[].ariaariaaction.ariaapp.ariadashboard.aria、dashboard.widgets[].aria、form view 的ariachart.arialiveness/chart.json不存在）objectui 侧佐证：
components/src/renderers/basic/elements.tsx四处ariaAttrs(props.aria)、plugin-list/src/ListView.tsx:2041-2044、plugin-detail的 record-path / record-quick-actions。所以处方只列举前三个无歧义的活载体。刻意不列
chart.aria：它有声明、没 ledger 行、没实测到 renderer 读 —— 把它写进「stays live on」正是在小尺度上重犯本 issue 要修的错。action.aria的 PARTIAL 只写在注释里，不进 parse 可达的处方。os migrate meta --from 16的动词该命令仍然该留 —— 转换确实覆盖这个键。但它做的是剥离不是搬迁：
conversions/registry.ts的dashboard-widget-action-aria-removed调用stripKeys(w, ['actionUrl','actionType','actionIcon','aria'], …)，fixture 的after里 widget 已无aria，expectedNotices: 4。故动词由 "to rewrite it automatically" 改为 "to remove it automatically" —— 后者是仓库既有措辞（component.zod.ts:770,781），不是新造。dashboard.mdx：生成，非手写content/docs/references/ui/dashboard.mdx:6明写{/* ⚠️ AUTO-GENERATED — DO NOT EDIT. Run build-docs.ts to regenerate. */}。因此未手改，走gen:docs重新生成；app.mdx（同样生成）与docs/protocol-upgrade-guide.md（gen:upgrade-guide）随源同步刷新。注意 issue 给的路径content/docs/dashboard.mdx不存在，实际是content/docs/references/ui/dashboard.mdx。接受集合逐字节不变
改动全部是
retiredKey()的 guidance 参数、注释、或 ledger 的note散文。retiredKey()无论字符串是什么都返回z.never({ error: () => guidance }).optional()。未触碰任何 key set / Zod 类型 /superRefine/ optionality。gen:schema独立复核：authorable-defaults/ verified — 1308 default(s) unchanged。反向验证（方向在跑之前先行预测）
预测：文本一半在还原后转红；结构一半两个方向都绿 —— 因为本 lane 的准入测试就是接受集合不变，它不允许翻转。
实测：把两个 guidance 字符串
git checkout origin/main --还原、测试保留修正后的期望：四条文本断言全红，两条结构断言（
really accepts/really rejects）在 150 passed 之中 —— 与预测完全一致。结构一半不是装饰：它是文本一半被比对的 ground truth，也是反空转保障。反空转单独取证：把
aria: retiredKey(…)整条删除（不是改措辞），新 pin 依然转红，且红在预期的那一条上：即：措辞漂移由枚举断言接住，整条消失由这条接住。
既有断言此前把缺陷钉死 —— 重新瞄准而非删除
sweep 发现两处既有测试要求保留错误声明，这也是我最初 pin 检索漏掉的（它们写成转义正则，字面量 grep 匹配不到）：
packages/spec/src/ui/dashboard.test.ts:588——expect(message).toMatch(/app\.aria/)。其注释的意图（"shared shape survives elsewhere"）是对的，被点名的实例是死面。已重新瞄准到活载体，并补上not.toMatch(/app\.aria/i)。packages/spec/src/ui/app.test.ts:1046——['aria', { label: 'x' }, 'component/widget']，期待片段正是错误的那一半。已重新瞄准到page.components[].aria。两处都保留了原有的守护力，属 fixture triage 的「re-spell / re-aim」而非「删除」。
验证
vitest run（packages/spec全量）Test Files 347 passed (347)/Tests 8881 passed (8881)pnpm --filter @objectstack/spec typechecktsc --noEmit+check:scripts-typecheck+check:test-typecheck；新测试文件零类型错误，未进test-typecheck-debt.json）check:livenesscheck:upgrade-guideprotocol-upgrade-guide.md is up to date.check:spec-changesspec-changes.json is up to date.check:docs230 generated files in sync with packages/specscripts/check-nul-bytes.mjs[\x00-\x08\x0b\x0c\x0e-\x1f\x7f]自扫，无命中scripts/check-type-check-coverage.mjsOK — 62/77 …。--re-measure需要整棵 build closure 才能跑；但packages/spec已在 #5286 从 TEST_DEBT 毕业，改为test-typecheck-debt.json的按文件棘轮（由上面的check:test-typecheck直接校验），故本改动无法触碰任何 TEST_DEBT 数字。Changeset
.changeset/aria-tombstone-dead-carrier.md——@objectstack/spec: patch。这是 parse 可达的作者可见散文（retiredKey()的 guidance 会原样出现在解析错误里，并被gen:docs发布到参考文档），不是纯注释改动，所以按 patch 发版而非skip-changeset。路由出本 lane 的发现
.changeset/dashboard-widget-action-aria-removed.md:58与packages/spec/CHANGELOG.md:604、packages/lint/CHANGELOG.md:295、content/docs/releases/v17.mdx同样带这句旧声明。均属历史记录（CHANGELOG 已消费，releases 按 CLAUDE.md 在代码 PR 中绝不触碰），故未改动，仅在此列出。Generated by Claude Code