Skip to content

test(spec): register sys_api_key in SINGLE_RECORD_WRITE_ONLY (queue-blocking)#7803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
huangyiirene wants to merge 1 commit into from
Closed

test(spec): register sys_api_key in SINGLE_RECORD_WRITE_ONLY (queue-blocking) #7803

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions packages/spec/src/data/api-methods-batch-conformance.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,14 +42,20 @@ const WRITE_PRIMITIVES = ['create', 'update', 'delete'] as const;

/**
* Objects that deliberately expose single-record writes but NO batch route,
* keyed by object name with the reason. Empty today: every tightened whitelist
* in the monorepo either grants `bulk` or grants no write verb at all.
* keyed by object name with the reason.
*
* Adding an entry is a real decision — batch denial is invisible until a user
* multi-selects rows and `data-objectstack` rethrows the 405 without falling
* back to per-row writes. Write down why the object is worth that.
*/
const SINGLE_RECORD_WRITE_ONLY: Record<string, string> = {};
const SINGLE_RECORD_WRITE_ONLY: Record<string, string> = {
sys_api_key:
"row actions revoke/restore (#7769/#7727) opened 'update' for a working " +
"PATCH /api/v1/data/sys_api_key/{id} route; 'create'/'delete' deliberately " +
"stay off apiMethods (minting is POST /api/v1/keys, retirement is revoking " +
'rather than deleting) — and batch revoke is not a declared product route, ' +
"so 'bulk' is intentionally withheld too. See #7769's commit message for the ruling.",
};

/** Every `*.object.ts` under `packages/`, skipping build output and deps. */
function walkObjectFiles(dir: string, out: string[] = []): string[] {
Expand Down
Loading