Skip to content

docs(objectql): correct two comments that still assert plugin-audit's retired captureBefore (#7707)#7883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huangyiirene merged 1 commit into from
Aug 12, 2026
Merged

docs(objectql): correct two comments that still assert plugin-audit's retired captureBefore (#7707) #7883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/objectql/src/engine.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -9106,7 +9106,9 @@ export class ObjectQL implements IObjectQLEngine {
// by `targets(objectName)` inside the handler)
// * `service-storage` file-reference-lifecycle before+afterDelete
// (filters by `activeFileFields(object)` inside)
// * `plugin-audit` captureBefore / writeAudit before+afterDelete,
// * `plugin-audit` writeAudit afterDelete only — #6656 retired
// `captureBefore`, which was its `beforeDelete` half,
// so it holds term 2 open and no longer term 1;
// global MINUS `excludeObjects: AUDIT_EXCLUDED_OBJECTS`
// (#5860) — the one that narrows at the ENGINE face,
// so `hookMatchesObject` can subtract it and an
Expand Down
3 changes: 2 additions & 1 deletion packages/objectql/src/plugin.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -981,7 +981,8 @@ export class ObjectQLPlugin implements Plugin {
// read. Two of the three were engine reads through the full read pipeline
// (middleware, RLS, field masking) and neither consulted any demand gate.
// This change removes one and makes the engine's the single producer;
// `captureBefore`'s now-redundant read is the identity lane's follow-up.
// `captureBefore`'s now-redundant read followed it out in #6656, which
// leaves the engine's gated read as the only producer on this path.
//
// ⛔ RETIRED — `sys_fetch_previous_delete` (#5929, ADR-0049
// enforce-or-remove). Do not reintroduce it.
Expand Down
Loading