Skip to content

docs(runtime): retire the dead objectui-lockstep rename promise in packages.ts - #7904

Merged
hotlong merged 1 commit into
mainfrom
claude/issue-7578-packages-comment-truth
Aug 12, 2026
Merged

docs(runtime): retire the dead objectui-lockstep rename promise in packages.ts#7904
hotlong merged 1 commit into
mainfrom
claude/issue-7578-packages-comment-truth

Conversation

@hotlong

Copy link
Copy Markdown
Contributor

Fixes#7578

What

Comment-only reword at packages/runtime/src/domains/packages.ts (the block documenting why the publish-drafts response keeps the unhiddenApps / unhideError wire-field spelling). The old text promised: "The rename rides the objectui follow-up card, together."

That follow-up card was #6955. Its dev measured the rename out rather than in: the server still emits the old names (unchanged emit sites — not touched by this PR) and objectui reads neither field anywhere (zero grep hits repo-wide). Under the card's own "rename in lockstep, or not at all" rule, the resolution was not at all — PM-ratified as option A: a rename of a zero-reader diagnostic payload buys no capability (startup-scope discipline).

The comment now records that settled state instead of pointing the next reader at work that will never arrive: the spellings are kept deliberately and permanently, cites #6955 for the measurement + ruling, and notes the option-B escape hatch (a standalone producer-side rename card) for anyone who later wants the vocabulary tidy on its own merits.

Scope proof

One file, one hunk, comment-only:

$ git diff --stat
packages/runtime/src/domains/packages.ts | 19 ++++++++++++++-----
1 file changed, 14 insertions(+), 5 deletions(-)

Zero behaviour change. The three emit sites the card called out as off-limits (unhideError assignment, unhiddenApps assignment, the metadata:reloaded announce read) are untouched — confirmed by diff review, not just by not editing them.

Tests

No new tests: comment-only diff has no observable behaviour to test.

Changeset

skip-changeset label applied — comment-only diff releases nothing.


Generated by Claude Code

…ckages.ts
The `unhiddenApps` / `unhideError` comment at packages.ts promised a
rename riding "the objectui follow-up card, together." That card was
#6955, whose dev measured the rename out rather than in: the server
still emits the old names and objectui reads neither field anywhere
(zero grep hits repo-wide), so the PM ratified "not at all" as option
A — a zero-reader diagnostic rename buys no capability. Reword the
comment to record that settled state, cite #6955, and note the
option-B escape hatch (a standalone producer-side rename card) for
anyone who later wants the vocabulary tidy on its own merits.
Comment-only; zero behaviour change. Fixes#7578.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B3Kurx8qufrDzNjk4rag7V
@vercel

vercelBot commented Aug 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
objectstackIgnoredIgnoredAug 12, 2026 3:32am

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

This PR changes 1 package(s): @objectstack/runtime.

20 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:

  • content/docs/api/client-sdk.mdx(via packages/runtime)
  • content/docs/api/index.mdx(via @objectstack/runtime)
  • content/docs/api/wire-format.mdx(via @objectstack/runtime)
  • content/docs/automation/hook-bodies.mdx(via @objectstack/runtime)
  • content/docs/concepts/metadata-lifecycle.mdx(via @objectstack/runtime)
  • content/docs/concepts/north-star.mdx(via packages/runtime)
  • content/docs/data-modeling/drivers.mdx(via @objectstack/runtime)
  • content/docs/deployment/index.mdx(via @objectstack/runtime)
  • content/docs/deployment/production-readiness.mdx(via @objectstack/runtime)
  • content/docs/deployment/single-project-mode.mdx(via @objectstack/runtime)
  • content/docs/deployment/vercel.mdx(via @objectstack/runtime)
  • content/docs/getting-started/your-first-project.mdx(via @objectstack/runtime)
  • content/docs/kernel/cluster.mdx(via @objectstack/runtime)
  • content/docs/permissions/authentication.mdx(via @objectstack/runtime)
  • content/docs/permissions/authorization.mdx(via packages/runtime)
  • content/docs/permissions/system-context.mdx(via packages/runtime)
  • content/docs/plugins/packages.mdx(via @objectstack/runtime)
  • content/docs/protocol/kernel/http-protocol.mdx(via @objectstack/runtime)
  • content/docs/protocol/kernel/index.mdx(via @objectstack/runtime)
  • content/docs/protocol/kernel/lifecycle.mdx(via @objectstack/runtime)

2 release-owned page(s) also reference the affected code. These are read-only:

  • content/docs/releases/implementation-status.mdx(via @objectstack/runtime)
  • content/docs/releases/v17.mdx(via @objectstack/runtime)

content/docs/releases/ is RELEASE-OWNED (AGENTS.md "Documentation Guardrails"): release
notes are written centrally at release time, and a code PR that edits them is the exact PR
that guardrail exists to stop. They are still audited — read-only. If one of them is actually
wrong, file an issue or open a dedicated docs-only PR; do not edit it here.

Advisory only. To re-verify, run the docs-accuracy-audit workflow scoped to these files:
node scripts/docs-audit/affected-docs.mjs origin/main → pass the list as args.docs.

@hotlonghotlong added skip-changeset PR has no user-facing published change; bypasses the changeset gate and removed size/s labels Aug 12, 2026 — with Claude
@hotlong
hotlong marked this pull request as ready for review August 12, 2026 03:45
@hotlong
hotlong added this pull request to the merge queueAug 12, 2026
Merged via the queue into main with commit d447939Aug 12, 2026
32 checks passed
@hotlong
hotlong deleted the claude/issue-7578-packages-comment-truth branch August 12, 2026 04:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changesetPR has no user-facing published change; bypasses the changeset gate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[finding] packages.ts:337 promises a wire-field rename that the objectui follow-up measured out — the comment is now a false pointer

2 participants

@hotlong@claude