Skip to content

docs(objectql): audit the three unverified delete-phase hook bullets — all correct, and the audit recorded (#7933)#8085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-zhuang merged 2 commits into from
Aug 12, 2026
Merged

docs(objectql): audit the three unverified delete-phase hook bullets — all correct, and the audit recorded (#7933) #8085

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a78d47
docs(objectql): record the delete-phase hook bullet audit for plugin-…
claude Aug 12, 2026
c577a57
Merge remote-tracking branch 'origin/main' into claude/issue-7933-pre…
claude Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions packages/objectql/src/engine.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -9331,6 +9331,19 @@ export class ObjectQL implements IObjectQLEngine {
// ⛔ Do not reintroduce it as a guard around the by-id read. A gate on
// whether to LOOK is not compatible with a rule about what to do when
// nothing is there. See `update()`'s twin.
//
// [#7933] The first three entries were carried here UNVERIFIED when
// #7707 corrected the `plugin-audit` one, which was wrong on BOTH halves
// — hook name and term. All three have since been read against the
// function that binds them — `registerIdentityWriteGuard`,
// `bindRecordShareCascade`, `installFileReferenceHooks` — and all three
// match what is claimed above: same events, same object-less
// registration, same in-handler filter. Nothing above needed changing.
// That audit is what the retirement note's "term 1 or 2 was already true
// for every object" stands on, so it is recorded here rather than left
// in a closed issue: the enumeration outlived the gate it was written
// for, and it is now load-bearing for a different claim than the one it
// was written to support.
const deleteSchema = this._registry.getObject(object);
// `buildDriverOptions` is what carries the open transaction and the
// tenant scope onto a raw driver read. Skipping it here would read
Expand Down
Loading