Skip to content

docs(metadata-protocol): fix stale where-slot arity note in ARRAY_VALUED_QUERY_SLOTS docblock#8151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huangyiirene merged 2 commits into from
Aug 12, 2026
Merged

docs(metadata-protocol): fix stale where-slot arity note in ARRAY_VALUED_QUERY_SLOTS docblock #8151

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3d4d6a
docs(metadata-protocol): fix stale where-slot arity note in ARRAY_VAL…
claude Aug 12, 2026
6bfb49b
Merge remote-tracking branch 'origin/main' into claude/issue-8003-arr…
claude Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/metadata-protocol/src/protocol.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -1747,8 +1747,13 @@ const WIRE_DOLLAR_ALIASES: readonly (readonly [string, string])[] = [
* and the array from either slot.
* - `where` — a FILTER AST is an array (`['status','=','open']`), so a
* blanket arity refusal here would reject the AST body form
* outright. A repeated `?filter=` is still refused, one
* block down, by `isFilterAST` failing to read it.
* outright. Arity for this slot is judged one layer up, at
* the REST querystring ingress (`assertFilterParamSuppliedOnce`,
* #7390) — the only layer that knows an array on this wire
* is a repetition and can be nothing else. A repeated
* `?filter=` never reaches this block on `GET /data/:object`;
* worse, `?filter=status&filter=%3D&filter=open` spells a
* valid AST and succeeds with a filter nobody expressed.
* - `groupBy` — `z.array(GroupByNodeSchema)`.
* - `aggregations` — `z.array(AggregationNodeSchema)`.
* - `joins` / `windowFunctions` — retired ARRAY keys (#4286). The tombstone,
Expand Down
Loading