Skip to content

test(scripts): gate the filter slot's wire-alias spellings against the normalizer's table (#8002)#8182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-zhuang merged 1 commit into from
Aug 12, 2026
+667 −0
Merged

test(scripts): gate the filter slot's wire-alias spellings against the normalizer's table (#8002) #8182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -333,6 +333,22 @@ jobs:
- name: Normalized metadata-type guard
run: pnpm check:meta-type-normalized

# Filter-slot wire-alias parity guard (#8002). The ONE filter slot is
# spelled four ways, declared in TWO packages: `where`/`filter` come from
# the spec table, while the wire-only `filters`/`$filter` are declared in
# `metadata-protocol` (no schema declares them) and named LITERALLY in
# `packages/rest`, which gates the slot's arity at the querystring ingress
# (#7390). A runtime import cannot join them — the normalizer's table is a
# module-private const, and metadata-protocol is only a devDependency of
# rest — so a fifth wire-only spelling would fold correctly and be
# silently ungated, putting repetition on it back on the misdiagnosis
# #7390 removed. The REST side alone is pinned by that card's §5 test;
# this covers the half it cannot reach. AST-based, and an unreadable
# declaration is RED rather than an empty corpus reported as a pass
# (#4690). Runs its own --self-test first.
- name: Filter-slot wire-alias parity guard
run: pnpm check:filter-alias-parity

# Init-service declaration guard (#4471, ADR-0116). The kernel's ordering
# contract (dependencies / optionalDependencies / requiresServices /
# providesServices) was complete but VOLUNTARY: a plugin that resolves
Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -60,6 +60,7 @@
"check:error-code-casing": "node scripts/check-error-code-casing.mjs --self-test && node scripts/check-error-code-casing.mjs",
"check:wildcard-fallthrough": "node scripts/check-wildcard-fallthrough.mjs --self-test && node scripts/check-wildcard-fallthrough.mjs",
"check:meta-type-normalized": "node scripts/check-meta-type-normalized.mjs --self-test && node scripts/check-meta-type-normalized.mjs",
"check:filter-alias-parity": "node scripts/check-filter-alias-parity.mjs --self-test && node scripts/check-filter-alias-parity.mjs",
"check:init-service-contract": "node scripts/check-init-service-contract.mjs --self-test && node scripts/check-init-service-contract.mjs",
"check:kernel-hook-pairs": "node scripts/check-kernel-hook-pairs.mjs --self-test && node scripts/check-kernel-hook-pairs.mjs",
"check:durability-log-level": "node scripts/check-durability-degradation-log-level.mjs --self-test && node scripts/check-durability-degradation-log-level.mjs",
Expand Down
Loading
Loading