Uh oh!
There was an error while loading. Please reload this page.
fix(spec): remove 8 dead page names from build-docs integration category - #8219
Merged
Merged
Conversation
`packages/spec/scripts/build-docs.ts`'s `integration` category listed 9 page names, 8 of which have never had a matching `.zod.ts` file in `packages/spec/src/integration/` since #4480 removed the per-provider connector template files. `buildCategoryPages` already filters by what was actually emitted, so the dead names were silently harmless — this removes them deliberately, matching the discipline the `automation` category's comments already established. `connector` is the only module `integration/` has ever emitted a page for. Verified with a fresh `gen:docs` run: 230 files before and after, byte-for- byte identical — the removal is inert by construction. Fixes#8166
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
📓 Docs Drift CheckNo hand-written docs reference the 0 changed package(s). ✅ |
os-zhuang
marked this pull request as ready for review
August 12, 2026 21:14
Uh oh!
There was an error while loading. Please reload this page.
Contributor
⛔ merge queue 构建失败 — 先分诊,再决定要不要重排队列构建 31641653166 红了。队列跑的是全量套件(PR 侧 CI 只跑 affected 子集), 失败的 job(日志抽取,best effort):
历史信号:
分诊清单:
Generated by Claude Code · merge-queue-triage workflow (#4859) |
huangyiirene pushed a commit
that referenced
this pull request
Aug 12, 2026
…ding lap, #8075) Merge a296d81 took main's side of every os-regen path; this regeneration recomputes them from the merged sources — the 8 retired defs and 39 authorable keys leave again (deliberate deletions re-applied under the manifest gate), main's audit-log semantic entry, page.zod/editability references and the build-docs integration fix (#8219) all survive. check:generated 13/13. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0123k4cam2jEAkPmbJeoaY3r
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#8166
What
packages/spec/scripts/build-docs.ts'sintegrationcategory (SECTION_GROUPS) listed 9 page names across 3 sections. Re-enumerated against a freshgen:docsrun rather than trusting the issue's count:packages/spec/src/integration/contains exactly one.zod.tsmodule (connector.zod.ts), andcontent/docs/references/integration/emits exactly one page (connector.mdx). So 8 of the 9 listed names are dead —mapping,translation,http,message-queue,object-storage,offline,tenant,misc— not the 9 the card's title/body claimed (that number was the size of the whole list, not the dead subset; the dispatch brief carried this correction and asked for re-derivation, which this PR's numbers reflect).The 8 names trace to #4480, which removed the per-provider connector template files (
connector/saas.zod.ts,connector/database.zod.ts, file-storage, message-queue, github, vercel) as the losing side of ADR-0023's rejected per-system modelling — ADR-0097's answer is that provider shapes come from the provider itself, not from the spec (packages/spec/src/integration/index.tsalready records this). TheSECTION_GROUPSentry was never updated to match.This integration-category
message-queueis that connector-template entry — not thesystemcategory's ownmessage-queue.zod.ts(#8075's surface, atbuild-docs.ts:519, untouched here) nordata'sexternal-lookup(:497, also #8075's, also untouched). #8075 had not landed onmainas of this branch's base; thedata/systemlists here are unmodified.Removed the 8 dead names and added a deliberate-removal comment, matching the style the
automationcategory already established in the same file (naming what was removed, why, and the issue number).Verification
packages/spec/scripts/build-docs.ts'sbuildCategoryPagesfiltersSECTION_GROUPSentries by what a run actually emits, so this change is a no-op on generated output by construction. Confirmed with a freshpnpm gen:schema && pnpm gen:docs: 230 files generated both before and after the edit (not the 228 the card cited — confirmed the real number), andgit status/git diffshow zero bytes changed undercontent/docs/references/— onlybuild-docs.tsitself differs.pnpm --filter @objectstack/spec check:docs(the--check/ CI mode): green, "230 generated files in sync with packages/spec".pnpm --filter @objectstack/spec typecheck: green (tsc --noEmit,check:scripts-typecheck,check:test-typecheck).pnpm --filter @objectstack/spec exec vitest run scripts --maxWorkers=2: 35 test files / 720 tests, all green.pnpm --filter @objectstack/spec exec eslint scripts/build-docs.ts: clean.check:adr-anchors,check:authz-resolver,check:changeset-gate-self-tests,check:cross-package-test-inputs(surfaced by a live re-derivation ofnode scripts/pm/dispatch-gates.mjsagainst the actual changed path — not in the original named list),pnpm --filter @objectstack/lint run check:doc-formula-expressions,check:docs-audit-scope,check:i18n,check:merge-driver,check:nul-bytes,check:quick-reference-counts,check:release-body,check:role-word,check:spec-parsed-alias.Out of scope
data/systempage lists in the same file — [security] Two more spec schemas permit inline credentials:ExternalDataSourceSchema.authentication(clientSecret/apiKey) andMessageQueueConfigSchema.sasl.password— census toward #7990's parked boundary-guard reopen trigger #8075, in flight separately.content/docs/releases/**— not touched, per standing rule.@objectstack/specis a published package, checked rather than assumed private).Generated by Claude Code