Skip to content

fix(cloud-connection): move install-local outside the cloud ternary in README example#8419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-zhuang merged 2 commits into from
Aug 13, 2026
+15 −1
Merged

fix(cloud-connection): move install-local outside the cloud ternary in README example #8419

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45c3738
fix(cloud-connection): move install-local outside the cloud ternary i…
claude Aug 13, 2026
3866536
docs(cloud-connection): explain why RuntimeConfigPlugin keeps '' unli…
claude Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion packages/cloud-connection/README.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -27,11 +27,25 @@ import {
const cloudUrl = resolveCloudUrl(); // OS_CLOUD_URL, 'off' disables

const plugins = [
// Cloud-gated: these ARE the control-plane client, so a resolved URL is
// their precondition. Skipped entirely when cloud is off.
...(cloudUrl ? [
new MarketplaceProxyPlugin({ controlPlaneUrl: cloudUrl }),
new MarketplaceInstallLocalPlugin({ controlPlaneUrl: cloudUrl }),
new CloudConnectionPlugin({ singleEnvironment: true, controlPlaneUrl: cloudUrl }),
] : []),
// NOT cloud-gated: this is the documented air-gapped path, so it mounts
// unconditionally. `cloudUrl || 'off'` — never the bare `cloudUrl` — because
// the constructor re-resolves whatever it is given through
// resolveCloudUrl(), which reads '' as "unset" and substitutes the public
// DEFAULT_CLOUD_URL. 'off' is one of the documented disable sentinels and
// is the value that actually resolves to no cloud.
new MarketplaceInstallLocalPlugin({ controlPlaneUrl: cloudUrl || 'off' }),
// NOT cloud-gated: features.marketplace is derived from what is actually
// mounted, not from this constructor call, so a cloud-less runtime reports
// marketplace: false on its own — there is nothing here to keep in sync.
// `''` here, unlike its neighbor above, is correct as-is: this plugin does
// NOT re-resolve controlPlaneUrl through resolveCloudUrl(), so '' means
// "stay on this origin" rather than "unset" — do not "fix" it to 'off'.
new RuntimeConfigPlugin({ controlPlaneUrl: '', singleEnvironment: true, installLocal: true }),
];
```
Expand Down
Loading