Fixes #8210: honest test-surface rationale for query-options/no-any-erasure

[qq9340100]

Fixes#8210

What

check:query-options-erasure's test-surface half was described — in the rule's own comments, and in the rationale carried into #8112's dispatch — as "type the options and the compiler catches a malformed bag." That is true for the sites the rule actually blocks (non-test code), but not for a large share of the sites the ratchet only counts (test code). This PR fixes the prose, not the behavior: same rule, same ratchet, same baseline, same ceiling.

Step 1 — the flagged unknown, measured (widens the finding)

Card asked: does a type-aware ESLint program check the excluded test files? No — and not narrowly: this repo runs no type-aware ESLint pass over ANY file, test or non-test.eslint.config.mjs uses @typescript-eslint/parser only for AST parsing; it never sets parserOptions.project (or any other type-information option) and registers no @typescript-eslint/eslint-plugin typed rule. So the finding widens rather than narrows — ESLint fills none of the gap tsconfig exclusions leave.

Positive control (planted, measured, then reverted — no test-file diff in this PR):

• Added const opts: EngineAggregateOptions = { aggregations: [{ func: 'count', alias: … }] } (wrong key — declared key is function) to packages/objectql/src/engine-aggregate-having.test.ts, which packages/objectql/tsconfig.json excludes via **/*.test.ts.
• pnpm --filter @objectstack/objectql typecheck → exit 0 (confirms the exclusion premise, still true on origin/main).
• pnpm exec eslint --no-inline-config packages/objectql/src/engine-aggregate-having.test.ts → 0 problems (confirms ESLint doesn't fill the gap either).
• File reverted; git diff against origin/main for that path is empty.

Second measured instance (per the claim comment): PR #8406's patch round independently hit the identical shape the same day — pnpm --filter @objectstack/lint typecheck structurally blind to 12 new TS2339s in packages/lint test files, caught only by the TEST_DEBT hidden-layer measurement. Cited in the prose as a cross-check, not re-derived here.

Step 2 — rewritten prose

Three spots, all comments/messages, no logic:

• eslint.config.mjs's QUERY_OPTIONS_TEST_GLOBS comment (the rule's own framing for the test-surface carve-out).
• scripts/check-query-options-erasure-ratchet.mjs's module header (the gate's own framing).
• diffRatchet's test-surface-growth error message (what a developer actually sees when the ceiling moves).

All three now say the same honest thing: where a package's tsconfig.json excludes **/*.test.ts, typing the options bag removes an any that would blind whatever type-aware tool eventually DOES run over the file (an editor's language service today; tsc itself the day the exclusion lifts) — it is a precondition, not a compiler guard, today.

Step 3 — the split, made inspectable (optional scope, done)

Intersected the ratchet's actual test-surface file list (measured via the same measure() the gate uses, with QUERY_OPTIONS_TEST_GLOBS lifted) against each site's package's own tsconfig.json:

	packages	files	sites
tsconfig excludes **/*.test.ts (uncaught by tsc)	objectql, runtime, spec, drivers/driver-mongodb, plugins/plugin-approvals, plugins/plugin-auth	24	143
tsconfig does NOT exclude (caught by tsc)	drivers/driver-memory, drivers/driver-sql, drivers/driver-sqlite-wasm	23	97
total	9	47	240

Recorded in the gate script's header so it's re-derivable rather than rediscoverable.

Hard boundary respected

No ratchet threshold, no baseline entry, no tsconfig exclusion touched. pnpm check:query-options-erasure verdict is byte-identical before/after this PR:

✓ query-options-erasure ratchet holds: 67 unswept non-test site(s) in 17 file(s), none new.
test surface: 240 site(s) in 47 file(s) — at the ceiling.
baseline key set verified against dd0f681: no files added.

Tests / gates run

• pnpm check:query-options-erasure (self-test + ratchet) — green, verdict unchanged (above).
• node scripts/check-nul-bytes.mjs — green (7611 files scanned, no raw control bytes).
• pnpm exec eslint --no-inline-config eslint.config.mjs scripts/check-query-options-erasure-ratchet.mjs — 0 problems.
• node scripts/pm/dispatch-gates.mjs eslint.config.mjs scripts/check-query-options-erasure-ratchet.mjs — no additional check family names either path; the named families above are the full local scope.

Not in scope

• Whether the ratchet's framing structure or the tsconfig exclusions themselves should change — different cards (TEST_DEBT owns the exclusions' plan).
• Sweeping any erasure site — the baseline and ceiling are untouched by design.

skip-changeset

Scripts + eslint-config prose only, nothing user-visible — applying skip-changeset on this PR.

---

Generated by Claude Code

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
objectstack	Ignored		Aug 13, 2026 1:18pm