Skip to content

test(rest): re-point the publish-classification sentinel at ThrownHttpError.declaredStatus#8814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qq9340100 merged 1 commit into from
Aug 15, 2026
+10 −7
Merged

test(rest): re-point the publish-classification sentinel at ThrownHttpError.declaredStatus #8814

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions packages/rest/src/package-publish-status-classification.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -394,12 +394,15 @@ describe('[#8131 / #8132] the predicate now judges this phrasing — and the ret

describe('[#8131] the producer re-throws exactly what the shared rule can map', () => {
/**
* `declaresHttpAnswer` keys on the STATUS channel — `.status` or
* `.statusCode` — and deliberately not on `.code`. Asked here of the shared
* rule with a sentinel `fallbackStatus` no producer declares: a resolved
* status that is still the sentinel means nothing was declared.
* `declaredStatus` keys on the STATUS channel — `.status` or `.statusCode`
* — and deliberately not on `.code`. Delegates to the shared rule's own
* `ThrownHttpError.declaredStatus` field (#8634) rather than hand-spelling
* the sentinel trick this used to probe with: present exactly when the
* throw declared a status of its own, absent when it did not — including
* the one case a `fallbackStatus`-probe cannot tell apart, a producer that
* declares `0`.
*/
const declaredStatus = (error: unknown) => resolveThrownHttpError(error, 0).status !== 0;
const declaredStatus = (error: unknown) => resolveThrownHttpError(error).declaredStatus !== undefined;

const SHAPES: Array<{ name: string; error: unknown; rethrown: boolean }> = [
{ name: '.status', error: Object.assign(new Error('x'), { status: 409 }), rethrown: true },
Expand DownExpand Up@@ -433,10 +436,10 @@ describe('[#8131] the producer re-throws exactly what the shared rule can map',
});

// The shared rule does record it…
const resolved = resolveThrownHttpError(driverError, 0);
const resolved = resolveThrownHttpError(driverError);
expect(resolved.declaredCode).toBe('ERR_SQLITE_ERROR');
// …while declaring NO status of its own, which is the signal that counts.
expect(resolved.status).toBe(0);
expect(resolved.declaredStatus).toBeUndefined();
expect(declaredStatus(driverError)).toBe(false);

// And had it been re-thrown, the door would have resolved it as an
Expand Down
Loading