Uh oh!
There was an error while loading. Please reload this page.
fix(metadata-protocol): say what the predicate covers, not what the repo runs, in driver-text-disclosure test - #8859
Merged
Conversation
…xt-disclosure test The module note and the test name both claimed "the two dialects this repo runs" / "the two engines this repo runs" — false: MySQL is measurably run here (driver-sql branches on it, CI stands up a live mysql:8.0 for a required check, and live 8.0.46 measurements landed merged driver fixes in #8621/#8622). The claim describes what the shared looksLikeInternalErrorLeak predicate COVERS, not what the repo runs; #8739 already landed the same correction in packages/types/src/error-leak.ts and this lands the same shape here. Also fixes a third instance of the same false claim in the DIALECTS matrix's doc comment ("the list of engines nobody here has run is unbounded") found while in the file — same file, same claim, so folded into this wording-only fix per the card's instruction. Wording only: no assertions, no DIALECTS matrix entries, and no position on whether MySQL is a supported deployment target (#8739, still open) changed. Test count and pass/fail behaviour unchanged. Fixes#8822 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
📓 Docs Drift CheckNo hand-written docs reference the 0 changed package(s). ✅ |
hotlong
marked this pull request as ready for review
August 15, 2026 11:33
hotlong
enabled auto-merge
August 15, 2026 11:33
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#8822
What
packages/metadata-protocol/src/protocol.driver-text-disclosure.test.tsclaimed, in twoplaces named on the card plus a third found while in the file, that this repo runs only
two SQL dialects. That is false — MySQL is measurably run here (
driver-sqlbranches onmysql/mysql2, CI stands up a livemysql:8.0for the requiredTemporal Conformance (live PG + MySQL)check, and live MySQL 8.0.46 measurements landedmerged driver fixes in #8621 / #8622). The file's substance was already correct — this is
a wording-only correction, landing the same shape #8739 already landed in
packages/types/src/error-leak.ts: say what the sharedlooksLikeInternalErrorLeakpredicate covers, not what the repo runs.
Three sites corrected, all in this one file:
COVERS".
recognises the two engines this repo runs, and none of the three it does nottorecognises the two engines the predicate covers, and none of the three it does not.DIALECTSmatrix's doc comment (notnamed on the card, same false claim, same file, folded in per the card's instruction):
"the list of engines nobody here has run is unbounded" to "the list of dialects this
predicate does not cover is unbounded".
What this explicitly does NOT do
expect(...)is untouched.DIALECTSmatrix change. The matrix deliberately includes dialects the predicate doesNOT recognise, asserts
looksLikeInternalErrorLeakreturnsfalsefor them, and thenasserts the text is withheld anyway so correctness never depends on having enumerated
the world's SQL engines. That design is preserved exactly as-is.
error-leak.tsasserts "nobody here runs" MySQL — but CI stands up a live mysql:8.0 for a required check, and the claim is load-bearing for security reasoning #8739'sand stays open; the correction is written to be true regardless of how it resolves.
Tests
At
9ca3831f2(HEAD):pnpm --filter '@objectstack/metadata-protocol^...' build— 0 (full dependency closurebuilt before testing).
pnpm --filter '@objectstack/metadata-protocol' test -- --maxWorkers=2— 1444/1444passed, 98/98 files, including the edited file's 16/16 tests (same count as before,
wording only).
pnpm check:cross-package-test-inputs— OK, 9 packages, all declared.pnpm check:durability-log-level— OK, 25 seams, all loud/declared.node scripts/check-cross-package-test-inputs.mjs— same as above (single script backingboth).
pnpm check:query-options-erasure— OK, ratchet holds, none new, baseline unchangedagainst
fd6bdf8.pnpm check:type-check-coverage— OK, structural coverage unchanged.pnpm check:type-check-debt --re-measure(on a fullturbo run buildof the workspace,70/70 tasks) — OK, 33 ledger entries re-measured, 1926 raw tsc errors total, none above
its recorded ceiling (no regression from this change).
Out of scope
None filed no defects found beyond the wording this card targets.
Generated by Claude Code